Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57AC1C2D0A3 for ; Tue, 3 Nov 2020 14:02:38 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BCD7322264 for ; Tue, 3 Nov 2020 14:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCD7322264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3D1BCA74; Tue, 3 Nov 2020 15:02:35 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 17D95CA6E for ; Tue, 3 Nov 2020 15:02:33 +0100 (CET) IronPort-SDR: HNjoUxaO731Pu6zD069hXVQn+P9qNswWlv72JlQ6GFguMcOGX0/zwlBtkZ3JPCW7Hzq+AVk+IQ h31Fg5REAvtA== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="169159560" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="169159560" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:02:22 -0800 IronPort-SDR: +lNg8d8yIlLvj4kZm0pfVEBnDbPDQ8vvCKrpNNSzqWVr83F9VHR2mcEoeJFJW7kR9M0TOvJOrd 6sQEpWq0QblA== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538499509" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:02:20 -0800 To: Andrew Boyer Cc: dev@dpdk.org, cardigliano@ntop.org References: <20201102183527.69209-1-aboyer@pensando.io> <20201102183527.69209-9-aboyer@pensando.io> From: Ferruh Yigit Message-ID: <51169b22-1bfb-2ef5-925c-80113d68af62@intel.com> Date: Tue, 3 Nov 2020 14:02:18 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 2:00 PM, Andrew Boyer wrote: > > >> On Nov 3, 2020, at 8:06 AM, Ferruh Yigit > > wrote: >> >> On 11/2/2020 6:35 PM, Andrew Boyer wrote: >>> These are minor cleanups which did not deserve their own patches. >>> Signed-off-by: Andrew Boyer > >>> --- >>>  drivers/net/ionic/ionic_ethdev.c | 10 ++++------ >>>  drivers/net/ionic/ionic_lif.c    | 22 ++++++++++----------- >>>  drivers/net/ionic/ionic_main.c   |  4 +--- >>>  drivers/net/ionic/ionic_rxtx.c   | 33 ++++++++++++++------------------ >>>  4 files changed, 29 insertions(+), 40 deletions(-) > >>> ... >> >> As far as I can see this patchset has, >> 1- minor fixes >> 2- some code refactoring >> 3- Whitespace updates >> >> Would you mind whitespace changes for now, and separate patch for 1 & 2? > > Please clarify - looks like there’s a word missing? > it is :) Would you mind leaving/dropping the whitespace changes for now, and have two separate patches for 1 & 2?