From: Arend van Spriel Date: Wed, 13 Feb 2013 19:54:19 +0100 Subject: [ath9k-devel] [PATCH 1/4] mac80211: Convert PS configuration from a binary flag to a set of modes In-Reply-To: <20130213170445.GC22867@thinkpad-t410> References: <1360184478-31481-1-git-send-email-seth.forshee@canonical.com> <1360184478-31481-2-git-send-email-seth.forshee@canonical.com> <1360767970.8868.24.camel@jlt4.sipsolutions.net> <20130213170445.GC22867@thinkpad-t410> Message-ID: <511BE15B.8090507@broadcom.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 02/13/2013 06:04 PM, Seth Forshee wrote: >> Is all this really worth it? It seems a quick fix for brcmsmac might be >> > to always set the powersave bit when IEEE80211_CONF_OFFCHANNEL is >> > enabled in the config, and then go implement a real solution like I >> > described earlier with powersave being separated out of the core >> > mac80211 routines, and actually made possible for multiple interfaces? > Using IEEE80211_CONF_OFFCHANNEL won't work. When the nullfunc to enable > PS is sent the flag won't be set, as we're still on the operating > channel. When we're actually off-channel the value of PM doesn't matter > for the types of frames which are being sent. The only quick fix I've > found is to watch out for frames with PM set and set the powersave bit > while they're being transmitted. I actually don't see that one fly. The frames are posted on a DMA fifo towards the hardware so in the driver we have no clue when that frame is being processes/transmitted hence no way of knowing when to write the register(s). Gr. AvS