Date: Thu, 16 Dec 2021 18:16:08 +0100 (CET) From: Frank Lichtenheld Message-ID: <512099266.1472890.1639674968820@...2642...> In-Reply-To: <20211207170211.3275837-10-arne@...1227...> References: <20211207170211.3275837-1-arne@...1227...> <20211207170211.3275837-10-arne@...1227...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 09/21] Rework occ link-mtu calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net > Arne Schwabe hat am 07.12.2021 18:01 geschrieben: > > > Use the functions that directly compute the link mtu instead relying on the > frame logic. Is the assumption that the old and new version of the calc_options_string_link_mtu functions should return the same values for the same configuration? I tried to actually test that with the UT, but they work so differently that it is difficult to adapt the test. So before going further down that rabbit hole I wanted to ask whether there is any sense in that or whether it is okay if they differ in the value calculated. Regards, -- Frank Lichtenheld