From: Wanlong Gao Subject: Re: [PATCH 11/16] virtio_rng: use simplified virtqueue accessors. Date: Wed, 20 Feb 2013 18:12:18 +0800 Message-ID: <5124A182.5080806@cn.fujitsu.com> References: <1361260594-601-1-git-send-email-rusty@rustcorp.com.au> <1361260594-601-12-git-send-email-rusty@rustcorp.com.au> Reply-To: gaowanlong@cn.fujitsu.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361260594-601-12-git-send-email-rusty@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: Paolo Bonzini , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/char/hw_random/virtio-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c > index 10fd71c..842e2d5 100644 > --- a/drivers/char/hw_random/virtio-rng.c > +++ b/drivers/char/hw_random/virtio-rng.c > @@ -47,7 +47,7 @@ static void register_buffer(u8 *buf, size_t size) > sg_init_one(&sg, buf, size); > > /* There should always be room for one buffer. */ > - if (virtqueue_add_buf(vq, &sg, 0, 1, buf, GFP_KERNEL) < 0) > + if (virtqueue_add_inbuf(vq, &sg, 1, buf, GFP_KERNEL) < 0) > BUG(); > > virtqueue_kick(vq); >