From: Clemens Ladisch Subject: Re: [PATCH] emu10k1: Fix coccicheck warning Date: Sun, 10 Mar 2013 17:32:07 +0100 Message-ID: <513CB587.5010304@ladisch.de> References: <1362919067-17250-1-git-send-email-cvicentiu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.29.28]) by alsa0.perex.cz (Postfix) with ESMTP id 8387426514E for ; Sun, 10 Mar 2013 17:33:17 +0100 (CET) In-Reply-To: <1362919067-17250-1-git-send-email-cvicentiu@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vicentiu Ciorbaru Cc: tiwai@suse.de, alsa-devel@alsa-project.org, wfp5p@virginia.edu, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Vicentiu Ciorbaru wrote: > Removed redundant cast of kmalloc return pointer. > - (icode->gpr_map = (u_int32_t __user *) > - kcalloc(512 + 256 + 256 + 2 * 1024, sizeof(u_int32_t), > - GFP_KERNEL)) == NULL || > + (icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024, > + sizeof(u_int32_t), GFP_KERNEL)) == NULL || Why would casting to __user be redundant? Regards, Clemens