From: gang.chen@asianux.com (Chen Gang) Date: Tue, 12 Mar 2013 08:01:43 +0800 Subject: [PATCH] ARM:net: an issue for k which is u32, never < 0 In-Reply-To: References: <513BECDA.3030803@asianux.com> Message-ID: <513E7067.5020809@asianux.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2013?03?12? 00:54, Mircea Gherzan ??: > 2013/3/10 Chen Gang : >> > >> > k is u32 which never < 0, need type cast, or cause issue. >> > >> > Signed-off-by: Chen Gang >> > --- >> > arch/arm/net/bpf_jit_32.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c >> > index 6828ef6..a0bd8a7 100644 >> > --- a/arch/arm/net/bpf_jit_32.c >> > +++ b/arch/arm/net/bpf_jit_32.c >> > @@ -576,7 +576,7 @@ load_ind: >> > /* x = ((*(frame + k)) & 0xf) << 2; */ >> > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL; >> > /* the interpreter should deal with the negative K */ >> > - if (k < 0) >> > + if ((int)k < 0) >> > return -1; >> > /* offset in r1: we might have to take the slow path */ >> > emit_mov_i(r_off, k, ctx); >> > -- >> > 1.7.7.6 > Acked-by: Mircea Gherzan > > thank you very much. :-) -- Chen Gang Asianux Corporation