Message-ID: <513F0219.6070709@...1227...> Date: Tue, 12 Mar 2013 11:23:21 +0100 From: Arne Schwabe MIME-Version: 1.0 References: <1363032625-23311-1-git-send-email-gert@...1296...> <513E4DEB.7000403@...1227...> <1CED409804E2164C8104F9E623B08B9013B8D6EDA6@...1436...> <20130312100706.GN953@...1296...> In-Reply-To: <20130312100706.GN953@...1296...> Content-Type: multipart/alternative; boundary="------------090902020309010502090501" Subject: Re: [Openvpn-devel] [PATCH v2] Repair "tcp server queue overflow" brokenness, more fallout. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gert Doering Cc: "openvpn-devel@lists.sourceforge.net" This is a multi-part message in MIME format. --------------090902020309010502090501 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 12.03.13 11:07, schrieb Gert Doering: > Hi, > > On Tue, Mar 12, 2013 at 09:32:36AM +0100, Steffan Karger wrote: >> Shouldn't the return type be size_t or at least unsigned int, as mbuf->len is also of type unsigned int? > > Well, unsigned int, as ->len is not a size_t. > > Not that it makes any real difference as we're talking about a range > between "0" and "65" here. But anyway. Patch v2 is below. > ACK to that too. Arne -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE/AhkACgkQe8+cMNS4zRfErwCcDvRSIfQ22qAT8C/PsNlaScUV L0YAoITnJqqV/D4HeLZFaXMf+B7k+ceG =FIBk -----END PGP SIGNATURE----- --------------090902020309010502090501 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 12.03.13 11:07, schrieb Gert Doering:
> Hi,
>
> On Tue, Mar 12, 2013 at 09:32:36AM +0100, Steffan Karger wrote:
>> Shouldn't the return type be size_t or at least unsigned int, as mbuf->len is also of type unsigned int?
>
> Well, unsigned int, as ->len is not a size_t. 
>
> Not that it makes any real difference as we're talking about a range
> between "0" and "65" here.  But anyway.  Patch v2 is below.
>

ACK to that too.

Arne
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlE/AhkACgkQe8+cMNS4zRfErwCcDvRSIfQ22qAT8C/PsNlaScUV
L0YAoITnJqqV/D4HeLZFaXMf+B7k+ceG
=FIBk
-----END PGP SIGNATURE-----

--------------090902020309010502090501--