From: Roger Quadros Subject: Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data Date: Tue, 12 Mar 2013 16:28:14 +0200 Message-ID: <513F3B7E.8000002@ti.com> References: <1363087466-32444-1-git-send-email-rogerq@ti.com> <1363087466-32444-2-git-send-email-rogerq@ti.com> <513F177D.40500@pengutronix.de> <513F37DD.9030301@ti.com> <513F38DF.5040404@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <513F38DF.5040404-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Marc Kleine-Budde Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 03/12/2013 04:17 PM, Marc Kleine-Budde wrote: > On 03/12/2013 03:12 PM, Roger Quadros wrote: >> On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote: >>> On 03/12/2013 12:24 PM, Roger Quadros wrote: >>>> Add clk_rate parameter to platform data. If supplied, the >>>> NOP phy driver will program the clock to that rate during probe. >>>> >>>> Also add 2 flags, needs_vcc and needs_reset. >>>> If the flag is set and the regulator couldn't be found >>>> then the driver will bail out with -EPROBE_DEFER. >>> >>> Is there a platform which fills out pdata.needs_vcc and >>> pdata.needs_reset? IMHO it makes no sense to add features for the non DT >>> case, if there isn't any user for it. >>> >> >> There can be a user in the non DT case as well. Consider the following example: > > I'm just saying, let the implementation up to a real user for the non DT > case. Beagleboard is ARM and there's no point of implementing non DT > fall backs for ARM, IMHO. > Why do you say so? It doesn't depend on the CPU architecture. It depends on how the board designer wired the board. A non ARM platform could also face the same problem as beagle. It is not a non DT fallback. I believe many are still using non DT boot and it needs to work at least till we move all functionality to purely DT. cheers, -roger