From: Daniel De Graaf Subject: Re: [PATCH 05 of 11 v4] xen: allow for explicitly specifying node-affinity Date: Fri, 15 Mar 2013 10:20:35 -0400 Message-ID: <51432E33.7080502@tycho.nsa.gov> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , Xen-Devel , Jan Beulich , Matt Wilson List-Id: xen-devel@lists.xenproject.org On 03/14/2013 10:30 PM, Dario Faggioli wrote: [...] > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -611,10 +611,10 @@ static int flask_domctl(struct domain *d > return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__UNPAUSE); > > case XEN_DOMCTL_setvcpuaffinity: > - return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__SETVCPUAFFINITY); > + return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__SETAFFINITY); > > case XEN_DOMCTL_getvcpuaffinity: > - return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__GETVCPUAFFINITY); > + return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__GETAFFINITY); You need to add XEN_DOMCTL_{get,set}nodeaffinity to the switch statement in addition to changing the permission name for the existing domctls. > case XEN_DOMCTL_resumedomain: > return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__RESUME); > diff --git a/xen/xsm/flask/policy/access_vectors b/xen/xsm/flask/policy/access_vectors > --- a/xen/xsm/flask/policy/access_vectors > +++ b/xen/xsm/flask/policy/access_vectors > @@ -103,10 +103,10 @@ class domain > max_vcpus > # XEN_DOMCTL_destroydomain > destroy > -# XEN_DOMCTL_setvcpuaffinity > - setvcpuaffinity > -# XEN_DOMCTL_getvcpuaffinity > - getvcpuaffinity > +# XEN_DOMCTL_setaffinity > + setaffinity > +# XEN_DOMCTL_getaffinity > + getaffinity > # XEN_DOMCTL_scheduler_op with XEN_DOMCTL_SCHEDOP_getinfo > getscheduler > # XEN_DOMCTL_getdomaininfo, XEN_SYSCTL_getdomaininfolist > The comments here are now incorrect, and should reflect the domctls controlled by the listed permission. -- Daniel De Graaf National Security Agency