Received: from eggs.gnu.org ([208.118.235.92]:40757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwbU-0001sr-FR for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHwbT-0000qn-1p for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:29:24 -0400 Message-ID: <51486831.4070802@suse.de> Date: Tue, 19 Mar 2013 14:29:21 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363692343-22299-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1363692343-22299-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] serial: Fix debug format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-trivial , qemu-devel@nongnu.org Am 19.03.2013 12:25, schrieb Kevin Wolf: > This fixes the build of hw/serial.c with DEBUG_SERIAL enabled. >=20 > Signed-off-by: Kevin Wolf > --- > hw/serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/serial.c b/hw/serial.c > index 48a5eb6..0ccc499 100644 > --- a/hw/serial.c > +++ b/hw/serial.c > @@ -306,7 +306,7 @@ static void serial_ioport_write(void *opaque, hwadd= r addr, uint64_t val, > SerialState *s =3D opaque; > =20 > addr &=3D 7; > - DPRINTF("write addr=3D0x%02x val=3D0x%02x\n", addr, val); > + DPRINTF("write addr=3D0x%" HWADDR_PRIx " val=3D0x%" PRIx64 "\n", a= ddr, val); Are you intentionally dropping 02 in both places? That changes output FWI= W. Andreas > switch(addr) { > default: > case 0: > @@ -527,7 +527,7 @@ static uint64_t serial_ioport_read(void *opaque, hw= addr addr, unsigned size) > ret =3D s->scr; > break; > } > - DPRINTF("read addr=3D0x%02x val=3D0x%02x\n", addr, ret); > + DPRINTF("read addr=3D0x%" HWADDR_PRIx " val=3D0x%02x\n", addr, ret= ); > return ret; > } > =20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg