Return-Path: Message-ID: <514F5480.6040501@suse.cz> Date: Sun, 24 Mar 2013 20:31:12 +0100 From: Jiri Slaby MIME-Version: 1.0 To: Sebastian Gottschall , linux-kernel@vger.kernel.org CC: stable@vger.kernel.org, Andrew Morton , keescook@chromium.org Subject: Build breakage in 3.8.4 [was: Linux 3.8.4] References: <20130320201554.GA18281@kroah.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 03/20/2013 11:25 PM, Sebastian Gottschall wrote: > Am 20.03.2013 21:15, schrieb Greg KH: >> I'm announcing the release of the 3.8.4 kernel. ... >> signal: always clear sa_restorer on execve > consider that this kernel is not compileable on mips targets due the > patch in kernel/signal.c > > SA_RESTORER is defined in mips, but sa_restorer does not exist on that > platform The same for ia64... kernel/signal.c: In function 'flush_signal_handlers': kernel/signal.c:441: error: 'struct sigaction' has no member named 'sa_restorer' Do we need this in 3.0, 3.4, 3.8 too? commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a Author: Andrew Morton Date: Wed Mar 13 14:59:34 2013 -0700 kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and later kernels, per Kees. thanks, -- js suse labs