From: Kamezawa Hiroyuki Subject: Re: [PATCH 04/12] memcg, kmem: fix reference count handling on the error path Date: Tue, 09 Apr 2013 11:51:39 +0900 Message-ID: <5163823B.4020109@jp.fujitsu.com> References: <5162648B.9070802@huawei.com> <516264D6.3090100@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <516264D6.3090100-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Li Zefan Cc: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org (2013/04/08 15:33), Li Zefan wrote: > From: Michal Hocko > > mem_cgroup_css_online calls mem_cgroup_put if memcg_init_kmem > fails. This is not correct because only memcg_propagate_kmem takes an > additional reference while mem_cgroup_sockets_init is allowed to fail as > well (although no current implementation fails) but it doesn't take any > reference. This all suggests that it should be memcg_propagate_kmem that > should clean up after itself so this patch moves mem_cgroup_put over > there. > > Unfortunately this is not that easy (as pointed out by Li Zefan) because > memcg_kmem_mark_dead marks the group dead (KMEM_ACCOUNTED_DEAD) if it > is marked active (KMEM_ACCOUNTED_ACTIVE) which is the case even if > memcg_propagate_kmem fails so the additional reference is dropped in > that case in kmem_cgroup_destroy which means that the reference would be > dropped two times. > > The easiest way then would be to simply remove mem_cgrroup_put from > mem_cgroup_css_online and rely on kmem_cgroup_destroy doing the right > thing. > > Signed-off-by: Li Zefan > Signed-off-by: Michal Hocko > Cc: # 3.8.x Acked-by: KAMEZAWA Hiroyuki