Message-ID: <5165221B.6040106@xenomai.org> Date: Wed, 10 Apr 2013 10:26:03 +0200 From: Philippe Gerum MIME-Version: 1.0 References: <1362068715-3458-1-git-send-email-sr@denx.de> <5164936A.8000005@xenomai.org> In-Reply-To: <5164936A.8000005@xenomai.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai] [PATCH] ipipe: MPC5200: Fix problem with external interrupts List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gilles Chanteperdrix Cc: Stefan Roese , Xenomai On 04/10/2013 12:17 AM, Gilles Chanteperdrix wrote: > On 02/28/2013 05:25 PM, Stefan Roese wrote: > >> The MPC5200 external interrupt are not working at all in the Linux >> context with the current I-pipe support enabled. For example a >> PCI firewire chip connected to an external interrupt doesn't generate >> interrupts any more using the Linux FW drivers. With I-pipe >> disabled or without the current I-pipe patch for the mpc52xx_pic.c >> file, the external interrupts work just fine. >> >> This patch now introduces the xxx_mask_ack() function for these >> external interrupts as already done for the other interrupts handled >> in this driver. With this change, the interrupts work regardless >> if I-pipe support is enabled or not. >> >> Additionally a small coding style issue has been included (spaces >> around "-"). >> >> Signed-off-by: Stefan Roese >> Cc: Philippe Gerum > > > Philippe, has this patch been forgotten? I can't seem to find it in the > core-next branch. > Stuck in my todo list. Pushed now, thanks. -- Philippe.