Received: from eggs.gnu.org ([208.118.235.92]:49132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTojv-0001jS-E0 for qemu-devel@nongnu.org; Sun, 21 Apr 2013 03:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTojs-0005rf-9X for qemu-devel@nongnu.org; Sun, 21 Apr 2013 03:31:11 -0400 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:34282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTojs-0005rZ-4x for qemu-devel@nongnu.org; Sun, 21 Apr 2013 03:31:08 -0400 Received: by mail-qc0-f175.google.com with SMTP id j3so2725825qcs.6 for ; Sun, 21 Apr 2013 00:31:07 -0700 (PDT) Sender: Richard Henderson Message-ID: <517395B6.9000900@twiddle.net> Date: Sun, 21 Apr 2013 09:31:02 +0200 From: Richard Henderson MIME-Version: 1.0 References: <1366498123-21182-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1366498123-21182-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg: fix deposit_i64 op on 32-bit targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Paolo Bonzini , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 2013-04-21 00:48, Aurelien Jarno wrote: > On 32-bit TCG targets, when emulating deposit_i64 with a mov_i32 + > deposit_i32, care should be taken to not overwrite the low part of > the second argument before the deposit when it is the same the > destination. > > This fixes the shld instruction in qemu-system-x86_64, which in turns > fixes booting "system rescue CD version 2.8.0" on this target. > > Reported-by: Michael S. Tsirkin > Cc: Richard Henderson > Cc: Paolo Bonzini > Signed-off-by: Aurelien Jarno Nice catch. Reviewed-by: Richard Henderson r~