From: Ben Greear Date: Sun, 28 Apr 2013 07:54:56 -0700 Subject: [ath9k-devel] [PATCH RFC] ath9k: collect statistics about Rx-Dup and Rx-STBC packets In-Reply-To: <517D1B45.9020302@openwrt.org> References: <1367076326-21616-1-git-send-email-linux@rempel-privat.de> <517D1B45.9020302@openwrt.org> Message-ID: <517D3840.2060000@candelatech.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 04/28/2013 05:51 AM, Felix Fietkau wrote: > On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >> Collect statistics about recived duplicate and STBC packets. >> This information should help see if STBC is actually working. >> >> Tested on ar9285; >> >> Signed-off-by: Oleksij Rempel > I thought about this patch some more, and I'm wondering what's the point > in doing this? These statistics are going to be completely useless for > most people and they'll waste some memory/cpu cycles, especially on > small-cache devices. I think it's much more useful to simply pass the > information to mac80211 via rx flags and get them added to the radiotap > header. > I'd like to keep the number of 'poor man's debug hacks' in the driver to > a minimum, and there are some other things that I think should be > removed: rx_frags and rx_beacons in struct ath_rx_stats, the tx/rx MAC > sampling hack, and pretty much anything else that can be just as easily > accessed from mac80211 through regular interfaces. Does that mean we can just put the stats in mac80211, or do we have to be running a sniffer to gather the stats? Thanks, Ben > > - Felix > _______________________________________________ > ath9k-devel mailing list > ath9k-devel at lists.ath9k.org > https://lists.ath9k.org/mailman/listinfo/ath9k-devel > -- Ben Greear Candela Technologies Inc http://www.candelatech.com