From: Daniel De Graaf Subject: Re: [PATCH 2/2] libxl: fix spelling of "backend-id" for vtpm Date: Mon, 29 Apr 2013 09:26:31 -0400 Message-ID: <517E7507.7080503@tycho.nsa.gov> References: <9b3a8a96a8c191b62bc52b257226ab12daf34811.1367113588.git.marmarek@invisiblethingslab.com> <1367224813.3142.210.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367224813.3142.210.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Marek Marczykowski , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/29/2013 04:40 AM, Ian Campbell wrote: > On Sun, 2013-04-28 at 00:17 +0100, Marek Marczykowski wrote: > > Adding Daniel. We need to confirm that this doesn't break compatibility > with existing frontends. If it does then we just have to live with it > IMHO. None of the frontends I can find rely on backend_id; in fact, they all rely on "backend-id" so this is a bug. The code in question is only reading, so it also couldn't have introduced bad frontend code elsewhere. >> Signed-off-by: Marek Marczykowski >> --- >> tools/libxl/libxl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c >> index e2c678a..7d0cd10 100644 >> --- a/tools/libxl/libxl.c >> +++ b/tools/libxl/libxl.c >> @@ -1855,7 +1855,7 @@ libxl_device_vtpm *libxl_device_vtpm_list(libxl_ctx *ctx, uint32_t domid, int *n >> vtpm->devid = atoi(*dir); >> >> tmp = libxl__xs_read(gc, XBT_NULL, >> - GCSPRINTF("%s/%s/backend_id", >> + GCSPRINTF("%s/%s/backend-id", >> fe_path, *dir)); >> vtpm->backend_domid = atoi(tmp); >>