From: Nicolas Ferre Subject: Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding Date: Mon, 29 Apr 2013 15:28:41 +0200 Message-ID: <517E7589.5030205@atmel.com> References: <1366362683-14496-1-git-send-email-ludovic.desroches@atmel.com> <1366362683-14496-2-git-send-email-ludovic.desroches@atmel.com> <51750F68.4040701@atmel.com> <20130423034407.GY24632@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from eusmtp01.atmel.com ([212.144.249.243]:5482 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700Ab3D2N2h (ORCPT ); Mon, 29 Apr 2013 09:28:37 -0400 In-Reply-To: <20130423034407.GY24632@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Vinod Koul Cc: ludovic.desroches@atmel.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-i2c@vger.kernel.org, plagnioj@jcrosoft.com, Linux Kernel list On 04/23/2013 05:44 AM, Vinod Koul : > On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote: >> On 04/19/2013 11:11 AM, ludovic.desroches@atmel.com : >>> From: Ludovic Desroches > >>> +#ifdef CONFIG_OF >>> +static bool at_dma_filter(struct dma_chan *chan, void *slave) > this is not defined for else case here. Also this could be CONFIG_DMA_OF...? in fact, at_dma_filter() is only used in corresponding dma_request_channel() in at_dma_xlate() function just below and only in case of CONFIG_OF. As the at_dma_xlate() is an empty function in !CONFIG_OF case, the at_dma_filter() is not needed. For the use of CONFIG_OF and not CONFIG_OF_DMA, it is simply because it it the directive that we currently use in drivers when we have to put the device tree condition around a piece of code. It is quite a common pattern I think. Moreover, it is what is used in dw_dmac.c and mv_xor.c... >>> +{ >>> + struct at_dma_slave *atslave = slave; >>> + >>> + if (atslave->dma_dev == chan->device->dev) { >>> + chan->private = atslave; >>> + return true; >>> + } else { >>> + return false; >>> + } >>> +} > > -- > ~Vinod Best regards, -- Nicolas Ferre