Received: from eggs.gnu.org ([208.118.235.92]:56371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZOLQ-0007uM-BI for qemu-devel@nongnu.org; Mon, 06 May 2013 12:32:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZOLP-0000U0-7a for qemu-devel@nongnu.org; Mon, 06 May 2013 12:32:56 -0400 Sender: Paolo Bonzini Message-ID: <5187DB2D.9080402@redhat.com> Date: Mon, 06 May 2013 18:32:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5187D656.2090501@siemens.com> In-Reply-To: <5187D656.2090501@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Rename readable flag to romd_mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-trivial , qemu-devel Il 06/05/2013 18:12, Jan Kiszka ha scritto: > "Readable" is a very unfortunate name for this flag because even a > rom_device region will always be readable from the guest POV. What > differs is the mapping, just like the comments had to explain already. > Also, readable could currently be understood as being a generic region > flag, but it only applies to rom_device regions. > > So name the flag and the function to modify it after the original term > "ROMD" which could also be interpreted as "ROM direct", i.e. ROM mode > with direct access. In any case, the scope if the flag is clearer now. > > Signed-off-by: Jan Kiszka > --- > > Depends on "memory: Replace open-coded memory_region_is_romd", but I > don't think this patch is "trivial" as well, though it is just renaming > things. Just in case, I'm CCing the trivial list as well. > > Paolo, or would you open a memory branch so that related stuff can flow > through one queue? I think this is more trivial than the other actually. :) (For code changes, I think trivial roughly means "if it compiles fine, it won't break anything"). For now I applied both patches to my iommu branch. I'll test it a bit more tomorrow and then post the IOMMU patches for review. We should merge them and the subpage reorg soon in 1.6, since it is (together with ref/unref) the main serialization point for all the work on BQL-less dispatch. BTW, a "trivial" patch would be one that actually defines the term "BQL" somewhere in the code. :) Paolo