From: Steve Dickson Subject: Re: [PATCH 13/17] NFS: Client implementation of Labeled-NFS Date: Wed, 08 May 2013 12:39:02 -0400 Message-ID: <518A7FA6.4090703@RedHat.com> References: <1367240239-19326-1-git-send-email-SteveD@redhat.com> <1367240239-19326-14-git-send-email-SteveD@redhat.com> <1367435005.4189.36.camel@leira.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "J. Bruce Fields" , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List To: "Myklebust, Trond" Return-path: In-Reply-To: <1367435005.4189.36.camel@leira.trondhjem.org> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 01/05/13 15:03, Myklebust, Trond wrote: >> @@ -2409,10 +2468,26 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f >> > server->caps |= NFS_CAP_CTIME; >> > if (res.attr_bitmask[1] & FATTR4_WORD1_TIME_MODIFY) >> > server->caps |= NFS_CAP_MTIME; >> > +#ifdef CONFIG_NFS_V4_SECURITY_LABEL >> > + if (res.attr_bitmask[2] & FATTR4_WORD2_SECURITY_LABEL) >> > + server->caps |= NFS_CAP_SECURITY_LABEL; >> > +#endif >> > + memcpy(server->attr_bitmask_nl, res.attr_bitmask, >> > + sizeof(server->attr_bitmask)); >> > + >> > + if (server->caps & NFS_CAP_SECURITY_LABEL) >> > + server->attr_bitmask_nl[2] &= ~FATTR4_WORD2_SECURITY_LABEL; >> > >> > memcpy(server->cache_consistency_bitmask, res.attr_bitmask, sizeof(server->cache_consistency_bitmask)); >> > server->cache_consistency_bitmask[0] &= FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE; >> > - server->cache_consistency_bitmask[1] &= FATTR4_WORD1_TIME_METADATA|FATTR4_WORD1_TIME_MODIFY; >> > + server->cache_consistency_bitmask[1] &= FATTR4_WORD1_TIME_METADATA | >> > + FATTR4_WORD1_TIME_MODIFY; >> > +#ifdef CONFIG_NFS_V4_SECURITY_LABEL >> > + server->cache_consistency_bitmask[2] &= FATTR4_WORD2_SECURITY_LABEL; > Why? How is the security label relevant to cache consistency? Its used to the set label bit in the GETATTR that goes out with ACCESS compound. steved.