Received: from eggs.gnu.org ([208.118.235.92]:56603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeJww-0001JW-2z for qemu-devel@nongnu.org; Mon, 20 May 2013 02:52:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeJwt-0008Oj-Cz for qemu-devel@nongnu.org; Mon, 20 May 2013 02:52:02 -0400 Message-ID: <5199C80A.9030804@msgid.tls.msk.ru> Date: Mon, 20 May 2013 10:51:54 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1369029900-9057-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Fix segfault with 9p2000.u List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-stable@nongnu.org, "Aneesh Kumar K.V" , qemu-devel 20.05.2013 10:10, Stefan Hajnoczi wrote: > On Mon, May 20, 2013 at 8:05 AM, Aneesh Kumar K.V > wrote: >> From: "Aneesh Kumar K.V" >> >> When guest tries to chmod a block or char device file over 9pfs, >> the qemu process segfaults. With 9p2000.u protocol we use wstat to >> change mode bits and client don't send extension information for >> chmod. We need to check for size field to check whether extension >> info is present or not. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> hw/9pfs/virtio-9p.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Stefan Hajnoczi Please also add Reported-by: Michael Tokarev Acked-by: Michael Tokarev /mjt