From: Chen Gang Subject: [PATCH] arch: frv: kernel: using strncmp() instead of memcmp() Date: Thu, 30 May 2013 11:13:33 +0800 Message-ID: <51A6C3DD.70209@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from intranet.asianux.com ([58.214.24.6]:8458 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759396Ab3E3DOZ (ORCPT ); Wed, 29 May 2013 23:14:25 -0400 Sender: linux-arch-owner@vger.kernel.org List-ID: To: "dhowells@redhat.com" , ak@linux.intel.com, Geert Uytterhoeven Cc: Andrew Morton , Greg KH , "linux-kernel@vger.kernel.org" , Linux-Arch 'cmdline' is a NUL terminated string, when its length < 4, memcmp() will cause memory access out of boundary. So need use strncmp() instead of memcmp(). Signed-off-by: Chen Gang --- arch/frv/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/frv/kernel/setup.c b/arch/frv/kernel/setup.c index a513647..622d5ee 100644 --- a/arch/frv/kernel/setup.c +++ b/arch/frv/kernel/setup.c @@ -735,7 +735,7 @@ static void __init parse_cmdline_early(char *cmdline) /* "mem=XXX[kKmM]" sets SDRAM size to , overriding the value we worked * out from the SDRAM controller mask register */ - if (!memcmp(cmdline, "mem=", 4)) { + if (!strncmp(cmdline, "mem=", 4)) { unsigned long long mem_size; mem_size = memparse(cmdline + 4, &cmdline); -- 1.7.7.6