Received: from eggs.gnu.org ([2001:4830:134:3::10]:42979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiPHA-0005m8-2y for qemu-devel@nongnu.org; Fri, 31 May 2013 09:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiPH5-0000hk-DY for qemu-devel@nongnu.org; Fri, 31 May 2013 09:21:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiPH5-0000he-5N for qemu-devel@nongnu.org; Fri, 31 May 2013 09:21:43 -0400 Message-ID: <51A8A3E1.9030605@redhat.com> Date: Fri, 31 May 2013 15:21:37 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1369722844-24345-1-git-send-email-kraxel@redhat.com> <1369722844-24345-3-git-send-email-kraxel@redhat.com> <51A89949.6040002@redhat.com> <51A89B69.5000307@redhat.com> In-Reply-To: <51A89B69.5000307@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa Cc: Anthony Liguori , qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com Hi, > Without this patch the returned message for "query-chardev" is: > > { > "return": [ > { > "filename": "pty:/dev/pts/8", > "label": "charserial0" > }, > { > "filename": "unix:/var/lib/libvirt/qemu/qemu-git.monitor,server", > "label": "charmonitor" > } > ], > "id": "libvirt-2" > } > > > this patch changes it to: > > { > "return": [ > { > "filename": "pty", > "label": "charserial0" > }, > { > "filename": "unix:/var/lib/libvirt/qemu/qemu-git.monitor,server", > "label": "charmonitor" > } > ], > "id": "libvirt-2" > } Please double-check. Current master (87d23f78aa79b72da022afda358bbc8a8509ca70 to be exact) works just fine for me. libvirt works, including a serial line redirected to pty, and 'info chardev' looks sane too. cheers, Gerd