Message-ID: <51AF96C5.5000507@msgid.tls.msk.ru>
Date: Wed, 05 Jun 2013 23:51:33 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1370434603-5394-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1370434603-5394-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: fix debug logs
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

05.06.2013 16:16, Herv=C3=A9 Poussineau wrote:
> 'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b9=
5c2.

It's been removed indeed, but the value has been replaced by using
a MemoryRegionSection instead.  I understand current code is wrong
when DEBUG_TLB is #defined, but I think it is also wrong to just
remove this value in printf.  The question is whenever this debugging
is useful now, and whenever this now-missing value is interesting
for that and should be provided by other means.  Maybe we may just
remove whole thing here and everywhere.

Cc'ing authors.

While this patch looks really trivial, it is something which is of
use by the subsystem maintainer(s) at their disposal.

Thanks,

/mjt

> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>  cputlb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/cputlb.c b/cputlb.c
> index 86666c8..1230e9e 100644
> --- a/cputlb.c
> +++ b/cputlb.c
> @@ -262,8 +262,8 @@ void tlb_set_page(CPUArchState *env, target_ulong v=
addr,
> =20
>  #if defined(DEBUG_TLB)
>      printf("tlb_set_page: vaddr=3D" TARGET_FMT_lx " paddr=3D0x" TARGET=
_FMT_plx
> -           " prot=3D%x idx=3D%d pd=3D0x%08lx\n",
> -           vaddr, paddr, prot, mmu_idx, pd);
> +           " prot=3D%x idx=3D%d\n",
> +           vaddr, paddr, prot, mmu_idx);
>  #endif
> =20
>      address =3D vaddr;
>=20