From: Ben Greear Date: Wed, 05 Jun 2013 20:50:49 -0700 Subject: [ath9k-devel] stop_machine lockup issue in 3.9.y. In-Reply-To: <1370490403.24311.322.camel@edumazet-glaptop> References: <51AE27D5.7050202@candelatech.com> <87sj0xry1k.fsf@rustcorp.com.au> <20130605071539.GA3429@mtj.dyndns.org> <51AF6E54.3050108@candelatech.com> <20130605184807.GD10693@mtj.dyndns.org> <51AF8D4B.4090407@candelatech.com> <51AF91F5.6090801@candelatech.com> <51AFA677.9010605@candelatech.com> <20130605211157.GK10693@mtj.dyndns.org> <1370482492.24311.308.camel@edumazet-glaptop> <20130606031444.GA12335@mtj.dyndns.org> <1370489181.24311.318.camel@edumazet-glaptop> <51B004CD.6080007@candelatech.com> <1370490403.24311.322.camel@edumazet-glaptop> Message-ID: <51B00719.20406@candelatech.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 06/05/2013 08:46 PM, Eric Dumazet wrote: > On Wed, 2013-06-05 at 20:41 -0700, Ben Greear wrote: >> On 06/05/2013 08:26 PM, Eric Dumazet wrote: >>> On Wed, 2013-06-05 at 20:14 -0700, Tejun Heo wrote: >>> >>>> >>>> Ah, so, that's why it's showing up now. We probably have had the same >>>> issue all along but it used to be masked by the softirq limiting. Do >>>> you care to revive the 10 iterations limit so that it's limited by >>>> both the count and timing? We do wanna find out why softirq is >>>> spinning indefinitely tho. >>> >>> Yes, no problem, I can do that. >> >> Limiting it to 5000 fixes my problem, so if you wanted it larger than 10, that would >> be fine by me. >> >> I can send a version of my patch easily enough if we can agree on the max number of >> loops (and if indeed my version of the patch is acceptable). > > Well, 10 was the prior limit and seems really fine. > > The non update on jiffies seems quite exceptional condition (I hope...) > > We use in Google a patch triggering warning is a thread holds the cpu > without taking care to need_resched() for more than xx ms Well, I'm sure that patch works nicely until the clock stops moving forward :) I'll post a patch with limit of 10 shortly. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com