Message-ID: <51B71545.3030508@msgid.tls.msk.ru>
Date: Tue, 11 Jun 2013 16:17:09 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <6740398.i518s4jboP@al>
In-Reply-To: <6740398.i518s4jboP@al>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Unbreak -no-quit for GTK,
 validate SDL options
To: Peter Wu <lekensteyn@gmail.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

11.06.2013 12:55, Peter Wu wrote:
> Certain options (-no-frame, -alt-grab, -ctrl-grab) only make sense with SDL.
> When compiling without SDL, these options (and -no-quit) print an error message
> and exit qemu.
> 
> In case QEMU is compiled with SDL support, the three aforementioned options
> still do not make sense with other display types. This patch addresses that
> issue by printing a warning. I have chosen not to exit QEMU afterwards because
> having the option is not harmful and before this patch it would be ignored
> anyway.
> 
> By delaying the sanity check from compile-time with some ifdefs to run-time,
> -no-quit is now also properly supported when compiling without SDL.

Thanks, this is also something I wanted to do for a long time, -- to know
when some options makes no sense (or not implemented) instead of wondering
what I did wrong and why it does not work as expected... ;)

Applied to the trivial patches queue.

/mjt