From: Fabio Estevam Subject: Re: [PATCH v2] sound/sgtl5000: fix codec register initial values and mask Date: Tue, 11 Jun 2013 13:01:57 -0300 Message-ID: <51B749F5.3010907@freescale.com> References: <51B71608.3000302@freescale.com> <1370964151-6728-1-git-send-email-oskar@scara.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1370964151-6728-1-git-send-email-oskar@scara.com> Sender: linux-kernel-owner@vger.kernel.org To: Oskar Schirmer Cc: Liam Girdwood , Andrew Morton , linux-kernel@vger.kernel.org, Zeng Zhaoming , alsa-devel@alsa-project.org, Takashi Iwai , Jaroslav Kysela , Mark Brown List-Id: alsa-devel@alsa-project.org On 06/11/2013 12:22 PM, Oskar Schirmer wrote: > According to documentation bit 3:2 in register SSS_CTRL are > reserved and zero, so initially setting the register to 0x0008 > does not make much sense. Instead, bit 4 should be marked set, > as this is the power up default. > > Further, mask computation in declarative part is obviously wrong: > Fix FRAC DIVISOR to provide an 11 bit mask correctly. > > Signed-off-by: Oskar Schirmer > Tested-by: Fabio Estevam Looks good, but please copy Mark Brown. Just added him in Cc now. > --- > sound/soc/codecs/sgtl5000.c | 2 +- > sound/soc/codecs/sgtl5000.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > index d441559..10092ba 100644 > --- a/sound/soc/codecs/sgtl5000.c > +++ b/sound/soc/codecs/sgtl5000.c > @@ -38,7 +38,7 @@ > static const struct reg_default sgtl5000_reg_defaults[] = { > { SGTL5000_CHIP_CLK_CTRL, 0x0008 }, > { SGTL5000_CHIP_I2S_CTRL, 0x0010 }, > - { SGTL5000_CHIP_SSS_CTRL, 0x0008 }, > + { SGTL5000_CHIP_SSS_CTRL, 0x0010 }, > { SGTL5000_CHIP_DAC_VOL, 0x3c3c }, > { SGTL5000_CHIP_PAD_STRENGTH, 0x015f }, > { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 }, > diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h > index 4b69229..52bd843 100644 > --- a/sound/soc/codecs/sgtl5000.h > +++ b/sound/soc/codecs/sgtl5000.h > @@ -347,7 +347,7 @@ > #define SGTL5000_PLL_INT_DIV_MASK 0xf800 > #define SGTL5000_PLL_INT_DIV_SHIFT 11 > #define SGTL5000_PLL_INT_DIV_WIDTH 5 > -#define SGTL5000_PLL_FRAC_DIV_MASK 0x0700 > +#define SGTL5000_PLL_FRAC_DIV_MASK 0x07ff > #define SGTL5000_PLL_FRAC_DIV_SHIFT 0 > #define SGTL5000_PLL_FRAC_DIV_WIDTH 11 > >