Message-ID: <51BB2488.1020309@suse.de>
Date: Fri, 14 Jun 2013 16:11:20 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370434603-5394-1-git-send-email-hpoussin@reactos.org>
	<51AF96C5.5000507@msgid.tls.msk.ru>
In-Reply-To: <51AF96C5.5000507@msgid.tls.msk.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: fix debug logs
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org

Am 05.06.2013 21:51, schrieb Michael Tokarev:
> 05.06.2013 16:16, Herv=C3=A9 Poussineau wrote:
>> 'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b=
95c2.
>=20
> It's been removed indeed, but the value has been replaced by using
> a MemoryRegionSection instead.  I understand current code is wrong
> when DEBUG_TLB is #defined, but I think it is also wrong to just
> remove this value in printf.  The question is whenever this debugging
> is useful now, and whenever this now-missing value is interesting
> for that and should be provided by other means.  Maybe we may just
> remove whole thing here and everywhere.

I interpret it as logging the function arguments, so dropping it sounded
like the right solution to me. Would be nice to turn it into a
tracepoint or at least some DPRINTF() macro that gets compile-tested.

Andreas

>=20
> Cc'ing authors.
>=20
> While this patch looks really trivial, it is something which is of
> use by the subsystem maintainer(s) at their disposal.
>=20
> Thanks,
>=20
> /mjt
>=20
>> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
>> ---
>>  cputlb.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/cputlb.c b/cputlb.c
>> index 86666c8..1230e9e 100644
>> --- a/cputlb.c
>> +++ b/cputlb.c
>> @@ -262,8 +262,8 @@ void tlb_set_page(CPUArchState *env, target_ulong =
vaddr,
>> =20
>>  #if defined(DEBUG_TLB)
>>      printf("tlb_set_page: vaddr=3D" TARGET_FMT_lx " paddr=3D0x" TARGE=
T_FMT_plx
>> -           " prot=3D%x idx=3D%d pd=3D0x%08lx\n",
>> -           vaddr, paddr, prot, mmu_idx, pd);
>> +           " prot=3D%x idx=3D%d\n",
>> +           vaddr, paddr, prot, mmu_idx);
>>  #endif
>> =20
>>      address =3D vaddr;
>>
>=20
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg