From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 16/22] drm/amdgpu: cleanup SA inti and fini Date: Mon, 26 Feb 2018 11:12:36 +0100 Message-ID: <51af9fc4-7827-9f40-da2b-0fd8753bc321@gmail.com> References: <1519622300-8990-1-git-send-email-Monk.Liu@amd.com> <1519622300-8990-17-git-send-email-Monk.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1519622300-8990-17-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Monk Liu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMjYuMDIuMjAxOCB1bSAwNjoxOCBzY2hyaWViIE1vbmsgTGl1Ogo+IHNob3VsZCB1c2UgYm9f Y3JlYXRlX2tlcm5lbCBpbnN0ZWFkIG9mIHNwbGl0IHRvIHR3bwo+IGZ1bmN0aW9uIHRoYXQgY3Jl YXRlIGFuZCBwaW4gdGhlIFNBIGJvCj4KPiBpc3N1ZToKPiBiZWZvcmUgdGhpcyBwYXRjaCwgdGhl cmUgYXJlIERNQVIgcmVhZCBlcnJvciBpbiBob3N0Cj4gc2lkZSB3aGVuIHJ1bm5pbmcgU1JJT1Yg dGVzdCwgdGhlIERNQVIgYWRkcmVzcyBkcm9wcGVkCj4gaW4gdGhlIHJhbmdlIG9mIFNBIGJvLgo+ Cj4gZml4Ogo+IGFmdGVyIHRoaXMgY2xlYW51cHMgb2YgU0EgaW5pdCBhbmQgZmluaSwgYWJvdmUg RE1BUgo+IGVyb3IgZ29uZS4KCldlbGwgdGhlIGNoYW5nZSBsb29rcyBsaWtlIGEgdmFsaWQgY2xl YW51cCB0byBtZSwgYnV0IHRoZSBleHBsYW5hdGlvbiAKd2h5IHRoYXQgc2hvdWxkIGJlIGEgcHJv YmxlbSBkb2Vzbid0IGxvb2tzIGxpa2UgaXQgbWFrZXMgc2Vuc2UuCgpQbGVhc2UgZXhwbGFpbiBm dXJ0aGVyIHdoYXQgdGhpcyBzaG91bGQgZml4PwoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPgo+IENo YW5nZS1JZDogSTNmMjk5YTMzNDJiZDcyNjM3NzZiZmY2OWU0YjMxYjBkMzgxNjc0OWEKPiBTaWdu ZWQtb2ZmLWJ5OiBNb25rIExpdSA8TW9uay5MaXVAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9pYi5jIHwgIDYgLS0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3NhLmMgfCA2MSArKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNjMgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2liLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaWIuYwo+IGluZGV4IDdm MmMzMTQuLjQ3MDlkMTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2liLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaWIu Ywo+IEBAIC0yNzksMTEgKzI3OSw2IEBAIGludCBhbWRncHVfaWJfcG9vbF9pbml0KHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2KQo+ICAgCQlyZXR1cm4gcjsKPiAgIAl9Cj4gICAKPiAtCXIgPSBh bWRncHVfc2FfYm9fbWFuYWdlcl9zdGFydChhZGV2LCAmYWRldi0+cmluZ190bXBfYm8pOwo+IC0J aWYgKHIpIHsKPiAtCQlyZXR1cm4gcjsKPiAtCX0KPiAtCj4gICAJYWRldi0+aWJfcG9vbF9yZWFk eSA9IHRydWU7Cj4gICAJaWYgKGFtZGdwdV9kZWJ1Z2ZzX3NhX2luaXQoYWRldikpIHsKPiAgIAkJ ZGV2X2VycihhZGV2LT5kZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIgZGVidWdmcyBmaWxlIGZvciBT QVxuIik7Cj4gQEAgLTMwMyw3ICsyOTgsNiBAQCB2b2lkIGFtZGdwdV9pYl9wb29sX2Zpbmkoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICB7Cj4gICAJaWYgKGFkZXYtPmliX3Bvb2xfcmVh ZHkpIHsKPiAgIAkJYW1kZ3B1X3NhX2JvX21hbmFnZXJfc3VzcGVuZChhZGV2LCAmYWRldi0+cmlu Z190bXBfYm8pOwo+IC0JCWFtZGdwdV9zYV9ib19tYW5hZ2VyX2ZpbmkoYWRldiwgJmFkZXYtPnJp bmdfdG1wX2JvKTsKPiAgIAkJYWRldi0+aWJfcG9vbF9yZWFkeSA9IGZhbHNlOwo+ICAgCX0KPiAg IH0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3NhLmMg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfc2EuYwo+IGluZGV4IDVjYTc1YTQu LjY5NWM2MzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3NhLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfc2EuYwo+IEBA IC02Myw4MCArNjMsMjcgQEAgaW50IGFtZGdwdV9zYV9ib19tYW5hZ2VyX2luaXQoc3RydWN0IGFt ZGdwdV9kZXZpY2UgKmFkZXYsCj4gICAJZm9yIChpID0gMDsgaSA8IEFNREdQVV9TQV9OVU1fRkVO Q0VfTElTVFM7ICsraSkKPiAgIAkJSU5JVF9MSVNUX0hFQUQoJnNhX21hbmFnZXItPmZsaXN0W2ld KTsKPiAgIAo+IC0JciA9IGFtZGdwdV9ib19jcmVhdGUoYWRldiwgc2l6ZSwgYWxpZ24sIHRydWUs IGRvbWFpbiwKPiAtCQkJICAgICAwLCBOVUxMLCBOVUxMLCAmc2FfbWFuYWdlci0+Ym8pOwo+ICsJ ciA9IGFtZGdwdV9ib19jcmVhdGVfa2VybmVsKGFkZXYsIHNpemUsIGFsaWduLCBkb21haW4sICZz YV9tYW5hZ2VyLT5ibywKPiArCQkJCSZzYV9tYW5hZ2VyLT5ncHVfYWRkciwgJnNhX21hbmFnZXIt PmNwdV9wdHIpOwo+ICAgCWlmIChyKSB7Cj4gICAJCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBm YWlsZWQgdG8gYWxsb2NhdGUgYm8gZm9yIG1hbmFnZXJcbiIsIHIpOwo+ICAgCQlyZXR1cm4gcjsK PiAgIAl9Cj4gICAKPiAtCXJldHVybiByOwo+IC19Cj4gLQo+IC12b2lkIGFtZGdwdV9zYV9ib19t YW5hZ2VyX2Zpbmkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gLQkJCSAgICAgICBzdHJ1 Y3QgYW1kZ3B1X3NhX21hbmFnZXIgKnNhX21hbmFnZXIpCj4gLXsKPiAtCXN0cnVjdCBhbWRncHVf c2FfYm8gKnNhX2JvLCAqdG1wOwo+IC0KPiAtCWlmICghbGlzdF9lbXB0eSgmc2FfbWFuYWdlci0+ b2xpc3QpKSB7Cj4gLQkJc2FfbWFuYWdlci0+aG9sZSA9ICZzYV9tYW5hZ2VyLT5vbGlzdCwKPiAt CQlhbWRncHVfc2FfYm9fdHJ5X2ZyZWUoc2FfbWFuYWdlcik7Cj4gLQkJaWYgKCFsaXN0X2VtcHR5 KCZzYV9tYW5hZ2VyLT5vbGlzdCkpIHsKPiAtCQkJZGV2X2VycihhZGV2LT5kZXYsICJzYV9tYW5h Z2VyIGlzIG5vdCBlbXB0eSwgY2xlYXJpbmcgYW55d2F5XG4iKTsKPiAtCQl9Cj4gLQl9Cj4gLQls aXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUoc2FfYm8sIHRtcCwgJnNhX21hbmFnZXItPm9saXN0LCBv bGlzdCkgewo+IC0JCWFtZGdwdV9zYV9ib19yZW1vdmVfbG9ja2VkKHNhX2JvKTsKPiAtCX0KPiAt CWFtZGdwdV9ib191bnJlZigmc2FfbWFuYWdlci0+Ym8pOwo+IC0Jc2FfbWFuYWdlci0+c2l6ZSA9 IDA7Cj4gLX0KPiAtCj4gLWludCBhbWRncHVfc2FfYm9fbWFuYWdlcl9zdGFydChzdHJ1Y3QgYW1k Z3B1X2RldmljZSAqYWRldiwKPiAtCQkJICAgICAgIHN0cnVjdCBhbWRncHVfc2FfbWFuYWdlciAq c2FfbWFuYWdlcikKPiAtewo+IC0JaW50IHI7Cj4gLQo+IC0JaWYgKHNhX21hbmFnZXItPmJvID09 IE5VTEwpIHsKPiAtCQlkZXZfZXJyKGFkZXYtPmRldiwgIm5vIGJvIGZvciBzYSBtYW5hZ2VyXG4i KTsKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiAtCX0KPiAtCj4gLQkvKiBtYXAgdGhlIGJ1ZmZlciAq Lwo+IC0JciA9IGFtZGdwdV9ib19yZXNlcnZlKHNhX21hbmFnZXItPmJvLCBmYWxzZSk7Cj4gLQlp ZiAocikgewo+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBmYWlsZWQgdG8gcmVzZXJ2ZSBt YW5hZ2VyIGJvXG4iLCByKTsKPiAtCQlyZXR1cm4gcjsKPiAtCX0KPiAtCXIgPSBhbWRncHVfYm9f cGluKHNhX21hbmFnZXItPmJvLCBzYV9tYW5hZ2VyLT5kb21haW4sICZzYV9tYW5hZ2VyLT5ncHVf YWRkcik7Cj4gLQlpZiAocikgewo+IC0JCWFtZGdwdV9ib191bnJlc2VydmUoc2FfbWFuYWdlci0+ Ym8pOwo+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBmYWlsZWQgdG8gcGluIG1hbmFnZXIg Ym9cbiIsIHIpOwo+IC0JCXJldHVybiByOwo+IC0JfQo+IC0JciA9IGFtZGdwdV9ib19rbWFwKHNh X21hbmFnZXItPmJvLCAmc2FfbWFuYWdlci0+Y3B1X3B0cik7Cj4gICAJbWVtc2V0KHNhX21hbmFn ZXItPmNwdV9wdHIsIDAsIHNhX21hbmFnZXItPnNpemUpOwo+IC0JYW1kZ3B1X2JvX3VucmVzZXJ2 ZShzYV9tYW5hZ2VyLT5ibyk7Cj4gICAJcmV0dXJuIHI7Cj4gICB9Cj4gICAKPiAgIGludCBhbWRn cHVfc2FfYm9fbWFuYWdlcl9zdXNwZW5kKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAg CQkJCSBzdHJ1Y3QgYW1kZ3B1X3NhX21hbmFnZXIgKnNhX21hbmFnZXIpCj4gICB7Cj4gLQlpbnQg cjsKPiAtCj4gICAJaWYgKHNhX21hbmFnZXItPmJvID09IE5VTEwpIHsKPiAgIAkJZGV2X2Vycihh ZGV2LT5kZXYsICJubyBibyBmb3Igc2EgbWFuYWdlclxuIik7Cj4gICAJCXJldHVybiAtRUlOVkFM Owo+ICAgCX0KPiAgIAo+IC0JciA9IGFtZGdwdV9ib19yZXNlcnZlKHNhX21hbmFnZXItPmJvLCB0 cnVlKTsKPiAtCWlmICghcikgewo+IC0JCWFtZGdwdV9ib19rdW5tYXAoc2FfbWFuYWdlci0+Ym8p Owo+IC0JCWFtZGdwdV9ib191bnBpbihzYV9tYW5hZ2VyLT5ibyk7Cj4gLQkJYW1kZ3B1X2JvX3Vu cmVzZXJ2ZShzYV9tYW5hZ2VyLT5ibyk7Cj4gLQl9Cj4gLQlyZXR1cm4gcjsKPiArCWFtZGdwdV9i b19mcmVlX2tlcm5lbCgmc2FfbWFuYWdlci0+Ym8sICZzYV9tYW5hZ2VyLT5ncHVfYWRkciwgJnNh X21hbmFnZXItPmNwdV9wdHIpOwo+ICsJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2 b2lkIGFtZGdwdV9zYV9ib19yZW1vdmVfbG9ja2VkKHN0cnVjdCBhbWRncHVfc2FfYm8gKnNhX2Jv KQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==