Received-SPF: neutral (google.com: 212.227.126.131 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.131;
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Eva Rachel Retuya <eraretuya@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: mt29f_spinand: Remove space after a cast
Date: Sun, 18 Oct 2015 14:55:56 +0200
Message-ID: <5200397.Z5PqNk5xTM@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151018101529.GA6434@Socrates-Mint>
References: <20151018101529.GA6434@Socrates-Mint>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Sunday 18 October 2015 18:16:09 Eva Rachel Retuya wrote:
> diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> index 1aa449e..cf98228 100644
> --- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
> +++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
> @@ -594,7 +594,7 @@ static int spinand_erase_block(struct spi_device *spi_nand, u16 block_id)
>                 if (retval < 0) {
>                         dev_err(&spi_nand->dev,
>                                         "error %d reading status register\n",
> -                                       (int) retval);
> +                                       (int)retval);
>                         return retval;


The change is correct, but it would be nicer to remove the cast as well,
because 'retval' is already an 'int'.

	Arnd