From: Daniel Wagner Subject: Re: [PATCH 22/23] cgroup: make cgroup_taskset deal with cgroup_subsys_state instead of cgroup Date: Tue, 6 Aug 2013 08:53:33 +0200 Message-ID: <52009D6D.10507@bmw-carit.de> References: <1375393801-4817-1-git-send-email-tj@kernel.org> <1375393801-4817-23-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1375393801-4817-23-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Matt Helsley , Steven Rostedt Hi Tejun, On 08/01/2013 11:50 PM, Tejun Heo wrote: > cgroup is in the process of converting to css (cgroup_subsys_state) > from cgroup as the principal subsystem interface handle. This is > mostly to prepare for the unified hierarchy support where css's will > be created and destroyed dynamically but also helps cleaning up > subsystem implementations as css is usually what they are interested > in anyway. > > cgroup_taskset which is used by the subsystem attach methods is the > last cgroup subsystem API which isn't using css as the handle. Update > cgroup_taskset_cur_cgroup() to cgroup_taskset_cur_css() and > cgroup_taskset_for_each() to take @skip_css instead of @skip_cgrp. > > The conversions are pretty mechanical. One exception is > cpuset::cgroup_cs(), which lost its last user and got removed. > > This patch shouldn't introduce any functional changes. > > Signed-off-by: Tejun Heo > Cc: Li Zefan > Cc: Ingo Molnar > Cc: Matt Helsley > Cc: Daniel Wagner > Cc: Steven Rostedt Nice cleanup. Acked-By: Daniel Wagner cheers, daniel