From: John Kacur Subject: Re: [OOPS] radeon kms Date: Tue, 26 Jan 2010 15:10:39 +0100 Message-ID: <520f0cf11001260610g7380e4c0y4496554e5700564f@mail.gmail.com> References: <20100115153852.GA13297@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alex Deucher Cc: Jerome Glisse , Jerome Glisse , Dave Airlie , Thomas Hellstrom , dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jan 26, 2010 at 2:59 PM, Alex Deucher w= rote: > On Tue, Jan 26, 2010 at 8:21 AM, John Kacur wrote= : >> >> >> On Fri, 15 Jan 2010, Jerome Glisse wrote: >> >>> On Fri, Jan 15, 2010 at 03:47:19PM +0100, John Kacur wrote: >>> > >>> > >>> > On Fri, 15 Jan 2010, John Kacur wrote: >>> > >>> > > The oops is triggered because I am missing the firmware for >>> > > radeon/R700_rlc.bin and >>> > > radeon/R600_rlc.bin >>> > > >>> > > However, I think it should be able to deal with this more grace= fully. >>> > > >>> > > ATOM BIOS: 9498.11.22.6.0.AS03 >>> > > [drm] Clocks initialized ! >>> > > [drm] Detected VRAM RAM=3D256M, BAR=3D256M >>> > > [drm] RAM width 128bits DDR >>> > > [TTM] Zone =A0kernel: Available graphics memory: 3050912 kiB. >>> > > [TTM] Zone =A0 dma32: Available graphics memory: 2097152 kiB. >>> > > [drm] radeon: 256M of VRAM memory ready >>> > > [drm] radeon: 512M of GTT memory ready. >>> > > =A0 alloc irq_desc for 33 on node -1 >>> > > =A0 alloc kstat_irqs on node -1 >>> > > radeon 0000:02:00.0: irq 33 for MSI/MSI-X >>> > > [drm] radeon: using MSI. >>> > > [drm] radeon: irq initialized. >>> > > [drm] GART: num cpu pages 131072, num gpu pages 131072 >>> > > [drm] Loading RV730 Microcode >>> > > platform radeon_cp.0: firmware: requesting radeon/RV730_pfp.bin >>> > > platform radeon_cp.0: firmware: requesting radeon/RV730_me.bin >>> > > platform radeon_cp.0: firmware: requesting radeon/R700_rlc.bin >>> > > r600_cp: Failed to load firmware "radeon/R700_rlc.bin" >>> > > [drm:rv770_startup] *ERROR* Failed to load firmware! >>> > > radeon 0000:02:00.0: ffff8801a20b5400 unpin not necessary >>> > > BUG: unable to handle kernel NULL pointer dereference at 000000= 0000000048 >>> > > IP: [] ttm_bo_reserve+0x16/0xf8 [ttm] >>> > > PGD 1a1a74067 PUD 1a19b8067 PMD 0 >>> > > Oops: 0000 [#1] SMP >>> > > last sysfs file: /sys/devices/platform/radeon_cp.0/firmware/rad= eon_cp.0/loading >>> > > CPU 4 >>> > > Pid: 168, comm: modprobe Not tainted 2.6.33-rc4 #3 EX58-UD3R/EX= 58-UD3R >>> > > RIP: 0010:[] =A0[] ttm_bo_r= eserve+0x16/0xf8 [t >>> > > tm] >>> > > RSP: 0018:ffff8801a1a8fb68 =A0EFLAGS: 00010292 >>> > > RAX: ffff880100000000 RBX: 0000000000000000 RCX: 00000000000000= 00 >>> > > RDX: 0000000000000000 RSI: 0000000000000001 RDI: 00000000000000= 48 >>> > > RBP: ffff8801a1a8fba8 R08: 0000000000000000 R09: 00000000000000= 00 >>> > > R10: 0000000000000000 R11: 0000000000000000 R12: 00000000000000= 00 >>> > > R13: ffff8801a8838000 R14: 0000000000000024 R15: 00000000000020= 00 >>> > > FS: =A000007f0f9c6dc700(0000) GS:ffff88002e400000(0000) knlGS:0= 000000000000000 >>> > > CS: =A00010 DS: 0000 ES: 0000 CR0: 000000008005003b >>> > > CR2: 0000000000000048 CR3: 00000001a195d000 CR4: 00000000000006= e0 >>> > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 00000000000000= 00 >>> > > DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 00000000000004= 00 >>> > > Process modprobe (pid: 168, threadinfo ffff8801a1a8e000, task f= fff8801a22c0000) >>> > > Stack: >>> > > =A0ffff880100000000 ffff8801a27e2900 ffff8801a1a8fb88 000000000= 0000000 >>> > > <0> 0000000000000000 ffff8801a8838000 0000000000000024 00000000= 00002000 >>> > > <0> ffff8801a1a8fbd8 ffffffffa00ba05b ffff8801a1a8fbd8 ffff8801= a27f4000 >>> > > Call Trace: >>> > > =A0[] radeon_bo_reserve.clone.0+0x2a/0x6d [ra= deon] >>> > > =A0[] rv770_suspend+0x43/0x69 [radeon] >>> > > =A0[] rv770_init+0x1a4/0x22d [radeon] >>> > > =A0[] radeon_device_init+0x27f/0x300 [radeon] >>> > > =A0[] radeon_driver_load_kms+0xff/0x184 [rade= on] >>> > > =A0[] drm_get_dev+0x3c4/0x4c5 [drm] >>> > > =A0[] ? pci_match_device+0x22/0xd0 >>> > > =A0[] radeon_pci_probe+0x15/0x268 [radeon] >>> > > =A0[] local_pci_probe+0x17/0x1b >>> > > =A0[] pci_device_probe+0xcd/0xfd >>> > > =A0[] ? driver_sysfs_add+0x4c/0x71 >>> > > =A0[] driver_probe_device+0xde/0x1fe >>> > > =A0[] __driver_attach+0x5d/0x81 >>> > > =A0[] ? __driver_attach+0x0/0x81 >>> > > =A0[] bus_for_each_dev+0x59/0x8e >>> > > =A0[] driver_attach+0x1e/0x20 >>> > > =A0[] bus_add_driver+0xd8/0x240 >>> > > =A0[] driver_register+0x9d/0x10e >>> > > =A0[] __pci_register_driver+0x68/0xd8 >>> > > =A0[] ? printk+0x41/0x47 >>> > > =A0[] ? radeon_init+0x0/0xc1 [radeon] >>> > > =A0[] drm_init+0x75/0xdb [drm] >>> > > =A0[] ? radeon_init+0x0/0xc1 [radeon] >>> > > =A0[] radeon_init+0xbf/0xc1 [radeon] >>> > > =A0[] do_one_initcall+0x5e/0x15e >>> > > =A0[] sys_init_module+0xd8/0x23a >>> > > =A0[] system_call_fastpath+0x16/0x1b >>> > > Code: 01 00 00 00 31 c0 48 83 c4 38 5b 41 5c 41 5d 41 5e 41 5f = c9 c3 55 48 89 e5 >>> > > =A041 57 41 56 41 55 41 54 53 48 83 ec 18 0f 1f 44 00 00 <4c> 8= b 27 48 89 fb 41 88 >>> > > =A0f5 41 88 d6 41 88 cf 44 89 45 c8 49 81 >>> > > RIP =A0[] ttm_bo_reserve+0x16/0xf8 [ttm] >>> > > =A0RSP >>> > > CR2: 0000000000000048 >>> > > ---[ end trace 604e2e318733e108 ]--- >>> > > udevd-work[166]: '/sbin/modprobe -b pci:v00001002d00009498sv000= 01043sd00000300bc >>> > > 03sc00i00' unexpected exit with status 0x0009 >>> > > >>> > > >>> > >>> > I forgot to mention that this is kernel version 2.6.33-rc4. >>> > >>> > Thanks. >>> >>> Yes, we didn't paid enough attention to failure path :( Sorry for t= hat >>> Fix should be in next rc, patch is: >>> http://git.kernel.org/?p=3Dlinux/kernel/git/airlied/drm-2.6.git;a=3D= commit;h=3D30d2d9a54d48e4fefede0389ded1b6fc2d44a522 >>> >> >> I think your fix didn't make it to 2.6.33-rc5 because I'm still oops= ing >> when I don't grab the firmware from the internet. (instead of merely >> reverting to vga mode). >> >> Furthermore, why is the firmware not shipped with the kernel? >> I never needed to fetch firmware for the 2.6.31 kernels and my graph= ic >> card worked fine. >> >> Am I right to conclude that the license is a problem? >> http://people.freedesktop.org/~agd5f/radeon_ucode/LICENSE.radeon >> >> This is a huge step backwards if we are exchanging a working driver = with >> what shipped with the linux kernel to one that only works with blobs= that >> don't ship with the kernel. > > In general, microcode is slowly being moved out of the kernel and int= o > the Linux firmware tree: > http://git.kernel.org/?p=3Dlinux/kernel/git/dwmw2/linux-firmware.git;= a=3Dtree > Eventually all of the radeon microcode will end up out up in that tre= e. > Okay, but why are R600_rlc.bin R700_rlc.bin in particular missing from the firmware?