Date: Tue, 7 Jun 2016 09:59:58 -0400 (EDT)
From: Bob Peterson <rpeterso@redhat.com>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <aviro@redhat.com>
Message-ID: <52112125.15651374.1465307998068.JavaMail.zimbra@redhat.com>
In-Reply-To: <501706658.15613331.1465307227820.JavaMail.zimbra@redhat.com>
Subject: Shouldn't iget_locked be using u64 rather than unsigned long ino?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org

Hi,

For a while now, I've been annoyed by the fact that function iget_locked
and friends (test_inode_iunique, find_inode_fast, ilookup, etc.) use
"unsigned long ino" rather than u64 for inode number. File systems need to be
consistent across multiple architectures, and 32-bits is hardly adequate for
modern storage. This can only result in problems and/or unnecessary restrictions
for file systems with block-number based inode numbers like gfs2, and/or force
them to kludge around it to prevent problems in mixed architectures.
(Not that anyone is likely to use GFS2 on a 32-bit arch, but still.) Opinions?

Regards,

Bob Peterson
Red Hat File Systems