From: Marc Kleine-Budde Date: Tue, 20 Aug 2013 11:01:36 +0200 Subject: [ath9k-devel] [PATCH v2] ath9k_htc: Restore skb headroom when returning skb to mac80211 In-Reply-To: <1376681980-27831-1-git-send-email-mkl@pengutronix.de> References: <1376681980-27831-1-git-send-email-mkl@pengutronix.de> Message-ID: <52133070.2050301@blackshift.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 08/16/2013 09:39 PM, Marc Kleine-Budde wrote: > From: Helmut Schaa > > ath9k_htc adds padding between the 802.11 header and the payload during > TX by moving the header. When handing the frame back to mac80211 for TX > status handling the header is not moved back into its original position. > This can result in a too small skb headroom when entering ath9k_htc > again (due to a soft retransmission for example) causing an > skb_under_panic oops. > > Fix this by moving the 802.11 header back into its original position > before returning the frame to mac80211 as other drivers like rt2x00 > or ath5k do. > > Reported-by: Marc Kleine-Budde > Signed-off-by: Helmut Schaa > Tested-by: Marc Kleine-Budde > Signed-off-by: Marc Kleine-Budde > --- > Hello Helmut, > > I've change the patch a bit, I've used ieee80211_get_hdrlen_from_skb() instead > of open coding it. > > Tested in ARMv5 with USB device > "ID 0cf3:7015 Atheros Communications, Inc. TP-Link TL-WN821N v3 802.11n [Atheros AR7010+AR9287]" > for four weeks. Without that patch the kernel oopes after about one week. > > I think this is a candidate for stable, can you add stable to Cc? ping Marc -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 897 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20130820/169cba71/attachment.pgp