Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D44F3C6369E for ; Thu, 19 Nov 2020 14:24:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB0EC238E6 for ; Thu, 19 Nov 2020 14:24:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB0EC238E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfkrZ-0004mE-2v for qemu-devel@archiver.kernel.org; Thu, 19 Nov 2020 09:24:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfkql-0004Ki-CS for qemu-devel@nongnu.org; Thu, 19 Nov 2020 09:23:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:34604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfkqj-0005F2-97 for qemu-devel@nongnu.org; Thu, 19 Nov 2020 09:23:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 507F9AF6F; Thu, 19 Nov 2020 14:22:46 +0000 (UTC) Subject: Re: [PATCH 0/5] i386: simplify Hyper-V enlightenments enablement To: Vitaly Kuznetsov , qemu-devel@nongnu.org References: <20201119103221.1665171-1-vkuznets@redhat.com> From: Claudio Fontana Message-ID: <5214378f-29fd-e562-ff99-c7868493c9fe@suse.de> Date: Thu, 19 Nov 2020 15:22:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201119103221.1665171-1-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 08:08:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Marcelo Tosatti , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Vitaly, I just wanted to raise awareness of https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg04597.html because if that series work is completed, you would have already the right hook to put your code in, when it comes to your hyperv-specific code for the realizefn. Ciao ciao, Claudio On 11/19/20 11:32 AM, Vitaly Kuznetsov wrote: > This series is a part of the previously sent "[PATCH RFC v3 00/23] i386: > KVM: expand Hyper-V features early": > https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02443.html > > We're not ready to merge the full patch set yet because the required > KVM capability is only queued for 5.11. We can, however, extract the > part providing 'hyperv=on' option to x86 machine types which is valuable > on its own. Picking up four other patches from the original RFC to > minimize the code churn in future (x86_cpu_realizefn()). > > Changes since RFCv3: > - Rename 'hyperv_features' to 'default_hyperv_features' in X86MachineClass > [Eduardo] > - Move x86_cpu_hyperv_realize() invocation after x86_cpu_expand_features()/ > x86_cpu_filter_features() as we need to reference cpu_has_vmx(). > > Vitaly Kuznetsov (5): > i386: move hyperv_vendor_id initialization to x86_cpu_realizefn() > i386: move hyperv_interface_id initialization to x86_cpu_realizefn() > i386: move hyperv_version_id initialization to x86_cpu_realizefn() > i386: move hyperv_limits initialization to x86_cpu_realizefn() > i386: provide simple 'hyperv=on' option to x86 machine types > > docs/hyperv.txt | 8 +++++ > hw/i386/x86.c | 30 +++++++++++++++++++ > include/hw/i386/x86.h | 7 +++++ > target/i386/cpu.c | 52 +++++++++++++++++++++++++++++++- > target/i386/cpu.h | 6 +++- > target/i386/kvm.c | 70 ++++++++++++++++++++++++++++--------------- > 6 files changed, 147 insertions(+), 26 deletions(-) >