Received: from eggs.gnu.org ([2001:4830:134:3::10]:48303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCz55-0000dA-L2 for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:39:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCz50-00082a-Nv for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:39:43 -0400 Received: from mo6-p00-ob.rzone.de ([2a01:238:20a:202:5300::1]:32760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCz50-00082F-Gg for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:39:38 -0400 Message-ID: <5217D699.7090502@markus-regensburg.de> Date: Fri, 23 Aug 2013 23:39:37 +0200 From: Tobias Markus MIME-Version: 1.0 References: <5217B34F.4090508@markus-regensburg.de> <5217BF9B.9040503@twiddle.net> In-Reply-To: <5217BF9B.9040503@twiddle.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Fix segment cache dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Richard Henderson On 08/23/2013 10:01 PM, Richard Henderson wrote: > On 08/23/2013 12:09 PM, Tobias Markus wrote: >> When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default operation size bit (D/B bit) is not set for Long Mode Data Segments since there are only Data Segments in Long Mode and no explicit 16/32/64-bit Descriptors. >> This patch fixes this by checking the Long Mode Active bit of the hidden flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data Segments are logged as "DS") >> >> Signed-off-by: Tobias Markus > > Reviewed-by: Richard Henderson > >> + cpu_fprintf(f, (sc->flags & DESC_B_MASK || >> + env->hflags & HF_LMA_MASK) >> + ? "DS " : "DS16"); > > Though we don't have anything in CODING_STYLE that mandates this, > IMO expressions shouldn't "unindent" in the middle like this. Other similar cpu_fprintf()s also "unindent"ed, so I aimed for consistency. I could submit a seperate patch to properly indent the relevant lines, but that seems like a seperate discussion. (Would be better to add it to CODING_STYLE, but that is obviously non-trivial and there are possibly many more files affected.) > > Better as > > cpu_fprintf(f, (sc->flags & DESC_B_MASK > || env->hflags & HF_LMA_MASK) > ? "DS " : "DS16"); > > but that's just me and emacs... > > > r~ > Alternatively, for readability: + cpu_fprintf(f, (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK) + ? "DS " : "DS16"); The upper line would be 82 characters long. I'm not sure how strictly line width is enforced. (Other lines in that file (target-i386/helper.c) also exceed the width limit.)