Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10275C43331 for ; Mon, 30 Mar 2020 16:17:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88F1F206CC for ; Mon, 30 Mar 2020 16:17:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GGeBJb3t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88F1F206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D477015F9; Mon, 30 Mar 2020 18:16:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D477015F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585585046; bh=DvUfddRc+M792WJZZKulhvtae49qPJARfOelVs2B70w=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GGeBJb3tKxCQjAKTLez7/i0XVnTnI+/9jLtc8WZQO+GCW3QcUST9Yl94xA+1jtdxi j+ydeMYIvxINJEqJNA2QlsQImBYck1MiReQWwLqbZAjZcTfRDlFZcXK/SuFEOUPDPl Q36UoZ8vMg1Hgm9uP3m1AzdOdqfIkVBzANIy2KB8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9B00AF80145; Mon, 30 Mar 2020 18:16:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 419FBF80148; Mon, 30 Mar 2020 18:10:58 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8D931F800AA for ; Mon, 30 Mar 2020 18:10:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8D931F800AA IronPort-SDR: 92aFtwZes2FuwHtaps5ay2z75rld4w05nrBB8DV7GEYHpFpfQa3E/PY2v2ywP8aTGwhztkYb3d 3d0dVsdX8OzA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 09:10:49 -0700 IronPort-SDR: aVzSFtUIUTK75DUyNOtA1SbMPfKyHHEToiV5qeklTQ0zFaUFF2lxqkIvG6/XBDg8dC9qI1dDnG lvzFr/or/mnw== X-IronPort-AV: E=Sophos;i="5.72,324,1580803200"; d="scan'208";a="395173983" Received: from aslawinx-mobl1.ger.corp.intel.com (HELO [10.249.135.1]) ([10.249.135.1]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 09:10:45 -0700 Subject: Re: [PATCH v2 3/6] ASoC: topology: Check return value of soc_tplg_*_create To: Pierre-Louis Bossart , Liam Girdwood , Mark Brown , Takashi Iwai References: <20200327204729.397-1-amadeuszx.slawinski@linux.intel.com> <20200327204729.397-4-amadeuszx.slawinski@linux.intel.com> <41ce872f-7fa5-74cd-396b-9bfae989e91c@linux.intel.com> <8e03a294-3562-7e26-6654-a5b0f7970060@linux.intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <521f1ccc-2c7c-aa9d-cb15-16ee16831e71@linux.intel.com> Date: Mon, 30 Mar 2020 18:10:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <8e03a294-3562-7e26-6654-a5b0f7970060@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Ranjani Sridharan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> Sounds good, but this happens in a loop, so would all the memory >>> previously allocated by denum/dbytes/dmixer_create leak, or is it >>> freed automatically somewhere else? >>> >> >> Well, now that error is propagated, snd_soc_tplg_component_remove() >> should be called by snd_soc_tplg_component_load() in case of errors >> while parsing. From quick look it seems like it should be able to free >> it up correctly by calling remove_enum/bytes/mixer. > > I am not sure what you meant by 'should be called', if it's a > recommendation for a future change or a description of the existing > behavior. > Just to be clear, are you saying the existing code will take care of > this error flow or that a new patch is needed? Existing code should handle this properly. No new code is needed.