From: David Vrabel Subject: Re: [PATCH RFC] xen/balloon: check whether a page is pointed to scratch page MFN Date: Thu, 5 Sep 2013 15:25:55 +0100 Message-ID: <52289473.4040107@citrix.com> References: <1378375219-28193-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VHaVU-0005Em-0D for xen-devel@lists.xenproject.org; Thu, 05 Sep 2013 14:26:00 +0000 In-Reply-To: <1378375219-28193-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 05/09/13 11:00, Wei Liu wrote: > Now that balloon pages might have two kind of P2M entries, a) > INVALID_P2M_ENTRY when that page is never used, b) mfn of one of the > many ballooned scratch pages. Refelct this in increase_reservation to > avoid hitting BUG_ON. This BUG_ON() isn't useful, please just remove it. David