Received: from eggs.gnu.org ([2001:4830:134:3::10]:33458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQMQX-0002Zk-9y for qemu-devel@nongnu.org; Sun, 29 Sep 2013 15:13:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQMQS-0002Ka-HV for qemu-devel@nongnu.org; Sun, 29 Sep 2013 15:13:09 -0400 Message-ID: <52487BAB.4010703@redhat.com> Date: Sun, 29 Sep 2013 21:12:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378625945-15525-1-git-send-email-linux@roeck-us.net> <5233E059.8090402@roeck-us.net> In-Reply-To: <5233E059.8090402@roeck-us.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guenter Roeck Cc: Peter Maydell , qemu-trivial , Michael Tokarev , qemu-devel@nongnu.org, Aurelien Jarno sh4 is ~orphan so nobody should complain if qemu-trivial picks this up as well. Paolo Il 14/09/2013 06:04, Guenter Roeck ha scritto: > On 09/08/2013 12:39 AM, Guenter Roeck wrote: >> With Linux kernel version 3.3 or later, qemu fails with the following >> message: >> >> sh_serial: unsupported read from 0x18 >> Aborted >> >> Reported-and-analyzed-by: Rob Landley >> Signed-off-by: Guenter Roeck > > ping ... > >> --- >> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html >> for Rob's analysis of the problem. Unfortunately, the patch never made it >> into qemu. >> >> hw/char/sh_serial.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c >> index 6223a55..9328dd1 100644 >> --- a/hw/char/sh_serial.c >> +++ b/hw/char/sh_serial.c >> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, >> hwaddr offs, >> s->flags &= ~SH_SERIAL_FLAG_RDF; >> } >> break; >> -#if 0 >> case 0x18: >> ret = s->fcr; >> break; >> -#endif >> case 0x1c: >> ret = s->rx_cnt; >> break; >> >