Received: from eggs.gnu.org ([2001:4830:134:3::10]:36263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQMlV-0005rY-0D for qemu-devel@nongnu.org; Sun, 29 Sep 2013 15:34:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQMlL-0007t5-8Q for qemu-devel@nongnu.org; Sun, 29 Sep 2013 15:34:48 -0400 Message-ID: <524880C3.6000801@msgid.tls.msk.ru> Date: Sun, 29 Sep 2013 23:34:27 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1380008620-13796-1-git-send-email-armbru@redhat.com> <1380008620-13796-2-git-send-email-armbru@redhat.com> In-Reply-To: <1380008620-13796-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org, qemu-devel@nongnu.org, anthony@codemonkey.ws, lersek@redhat.com, afaerber@suse.de 24.09.2013 11:43, armbru@redhat.com wrote: > From: Markus Armbruster > > Commit 4f193e3 added the test, but screwed up in-tree builds > (SRCDIR=.): the tests's output overwrites the expected output, and is > thus compared to itself. [] > .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y)) > $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: $(SRC_PATH)/%.json > - $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.out 2>$*.err; echo $$? >$*.exit, " TEST $*.out") > - @diff -q $(SRC_PATH)/$*.out $*.out > - @diff -q $(SRC_PATH)/$*.err $*.err > - @diff -q $(SRC_PATH)/$*.exit $*.exit > + $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; echo $$? >$*.test.exit, " TEST $*.out") > + @diff -q $(SRC_PATH)/$*.out $*.test.out > + @diff -q $(SRC_PATH)/$*.err $*.test.err > + @diff -q $(SRC_PATH)/$*.exit $*.test.exit Hmm. Maybe these new files should be cleaned up somehow by `make clean' ? Thanks, /mjt