Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18CEEC04A94 for ; Fri, 4 Aug 2023 10:14:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 598618681D; Fri, 4 Aug 2023 12:14:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="agrwzXsE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 83706868A1; Fri, 4 Aug 2023 12:14:36 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 352E6867CA for ; Fri, 4 Aug 2023 12:14:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 374AEVwP000972; Fri, 4 Aug 2023 05:14:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691144071; bh=6fNpA7/awcA0BTqYGJg0w/dtujYJfsLcfs/G9Ki6ubA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=agrwzXsE/UbK4uPq8zNgulzrKEqLu0+TrGu36Mk4v+FFORdQD/89HyTn9QyPrXD1m TXEOu+MVVxU29nE+8STXiMWrSGaBP8/5Jr8vGjdzFr7+42SEQK6nnskptsRTZ1pRs5 9p8qPNd8LwPbTVuSpJLMaqXVYdKVU9wgYtaHBgVQ= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 374AEVch011128 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 4 Aug 2023 05:14:31 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 4 Aug 2023 05:14:31 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 4 Aug 2023 05:14:31 -0500 Received: from [10.24.68.114] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 374AESCF057173; Fri, 4 Aug 2023 05:14:29 -0500 Message-ID: <524fe06c-6d0c-ccf1-730d-2cae80260e4e@ti.com> Date: Fri, 4 Aug 2023 15:44:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 3/4] arm: dts: k3-binman: fix rcfg_yaml and pcfg_yaml labels Content-Language: en-US To: Marcel Ziswiler , CC: Nishanth Menon , Bryan Brattlof , Marcel Ziswiler , Simon Glass , Tom Rini References: <20230804100808.110072-1-marcel@ziswiler.com> <20230804100808.110072-4-marcel@ziswiler.com> From: Neha Malcom Francis In-Reply-To: <20230804100808.110072-4-marcel@ziswiler.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marcel On 04/08/23 15:38, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Fix rcfg_yaml to really point to rm-cfg.yaml and pcfg_yaml to really > point to pm-cfg.yaml which likely is the intention. > > While at it also add labels for the remaining items like custmpk_pem, > dkey_pem, bcfg_yaml_sysfw, scfg_yaml_sysfw, pcfg_yaml_sysfw and > rcfg_yaml_sysfw. > > Signed-off-by: Marcel Ziswiler > > --- > > Changes in v6: > - New commit fixing rcfg_yaml and pcfg_yaml labels actually pointing > at correct yamls and adding labels for the remaining items. > Thanks to Neha for pointing me towards actually making use of those > labels. > > arch/arm/dts/k3-binman.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/dts/k3-binman.dtsi b/arch/arm/dts/k3-binman.dtsi > index 2a67cebf94f..2ea2dd18a12 100644 > --- a/arch/arm/dts/k3-binman.dtsi > +++ b/arch/arm/dts/k3-binman.dtsi > @@ -12,14 +12,14 @@ > &binman { > custMpk { > filename = "custMpk.pem"; > - blob-ext { > + custmpk_pem: blob-ext { > filename = "../keys/custMpk.pem"; > }; > }; > > ti-degenerate-key { > filename = "ti-degenerate-key.pem"; > - blob-ext { > + dkey_pem: blob-ext { > filename = "../keys/ti-degenerate-key.pem"; > }; > }; > @@ -37,14 +37,14 @@ > }; > pm-cfg { > filename = "pm-cfg.bin"; > - rcfg_yaml: ti-board-config { > + pcfg_yaml: ti-board-config { > config = "pm-cfg.yaml"; > schema = "../common/schema.yaml"; > }; > }; > rm-cfg { > filename = "rm-cfg.bin"; > - pcfg_yaml: ti-board-config { > + rcfg_yaml: ti-board-config { > config = "rm-cfg.yaml"; > schema = "../common/schema.yaml"; > }; Thanks for catching these as well! > @@ -93,19 +93,19 @@ > combined-sysfw-cfg { > filename = "combined-sysfw-cfg.bin"; > ti-board-config { > - board-cfg { > + bcfg_yaml_sysfw: board-cfg { > config = "board-cfg.yaml"; > schema = "../common/schema.yaml"; > }; > - sec-cfg { > + scfg_yaml_sysfw: sec-cfg { > config = "sec-cfg.yaml"; > schema = "../common/schema.yaml"; > }; > - pm-cfg { > + pcfg_yaml_sysfw: pm-cfg { > config = "pm-cfg.yaml"; > schema = "../common/schema.yaml"; > }; > - rm-cfg { > + rcfg_yaml_sysfw: rm-cfg { > config = "rm-cfg.yaml"; > schema = "../common/schema.yaml"; > }; Reviewed-by: Neha Malcom Francis -- Thanking You Neha Malcom Francis