Received: from multi.imgtec.com ([194.200.65.239]:47836 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6868729Ab3JGP24dRgW9 (ORCPT ); Mon, 7 Oct 2013 17:28:56 +0200 Message-ID: <5252D343.6090100@imgtec.com> Date: Mon, 7 Oct 2013 16:29:07 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build References: <1381158642-10598-1-git-send-email-treding@nvidia.com> In-Reply-To: <1381158642-10598-1-git-send-email-treding@nvidia.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Thierry Reding , Ralf Baechle Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Message-ID: <20131007152907.gAVQyiutopqwZ2nd6ofoH3TpjYQ8PhXPZIEibx64xDc@z> On 10/07/13 16:10, Thierry Reding wrote: > All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but > the ACX register declaration in struct pt_regs is still protected by it, > causing builds to fail. Remove the #ifdef protection and always declare > the register. > > Signed-off-by: Thierry Reding > --- > arch/mips/include/asm/ptrace.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h > index 7bba9da..d47bdce 100644 > --- a/arch/mips/include/asm/ptrace.h > +++ b/arch/mips/include/asm/ptrace.h > @@ -33,9 +33,7 @@ struct pt_regs { > unsigned long cp0_status; > unsigned long hi; > unsigned long lo; > -#ifdef CONFIG_CPU_HAS_SMARTMIPS > unsigned long acx; > -#endif > unsigned long cp0_badvaddr; > unsigned long cp0_cause; > unsigned long cp0_epc; > Hi Thierry, Looks good to me. Thanks! Reviewed-by: Markos Chandras