From: "plaisthos (Code Review)"
Date: Tue, 1 Apr 2025 11:44:12 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., antonio@...2726...
Message-ID: <5257f54f370a8578035ff0fbb573c79c3b690f1d-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="4XqE3gFqsVs="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use
SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--4XqE3gFqsVs=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/927?usp=3Demail )
Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_si=
gnature_nid
......................................................................
Patch Set 4:
(1 comment)
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/927/comment/2c6e0983_be364558 :
PS4, Line 2462: const char *signame =3D NULL;
> I presume you added the empty line on the wrong side? [=E2=80=A6]
No. As signame belongs to the block below as helper variable while the othe=
r are valid for the whole function.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/927?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6
Gerrit-Change-Number: 927
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Tue, 01 Apr 2025 11:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--4XqE3gFqsVs=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">File src/openvpn/ssl_openssl.c:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set #4, Line 2462=
: const char *signa=
me =3D NULL;
I presume you added the empty line on th=
e wrong side? [=E2=80=A6]
No. As signame belongs to the block below as help=
er variable while the other are valid for the whole function.
=
To view, visit change 927. To unsubscribe, or for help writing mail=
filters, visit settings=
.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72=
ac042be46cad6
Gerrit-Change-Number: 927
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...> =
div>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Tue, 01 Apr 2025 11:44:12=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--4XqE3gFqsVs=--