Content-Type: multipart/mixed; boundary="===============8043671622704997330==" MIME-Version: 1.0 From: Codrin.Ciubotariu@microchip.com To: kbuild-all@lists.01.org Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning Date: Wed, 09 Mar 2022 07:55:01 +0000 Message-ID: <52685dd2-593f-d39b-0f57-e6cf31bb4f2e@microchip.com> In-Reply-To: <20220309065849.96165-1-alviro.iskandar@gnuweeb.org> List-Id: --===============8043671622704997330== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 09.03.2022 08:58, Alviro Iskandar Setiawan wrote: > In function mchp_pdmc_af_put(), Intel's kernel test robot reports the > following warning: > = > sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \ > 'uvalue->value.integer.value' will always evaluate to 'true' \ > [-Wpointer-bool-conversion] > = > This is because we are using `uvalue->value.integer.value` which its > type is `long value[128];` for conditional expression and that array > will always decay to a non-NULL pointer. Using a non-NULL pointer for > conditional expression will always evaluate to true. > = > Fix this by changing it to `uvalue->value.integer.value[0]` as that's > what the mchp_pdmc_af_get() function sets. > = > To: Mark Brown > Cc: Codrin Ciubotariu > Cc: Nugraha > Cc: llvm(a)lists.linux.dev > Cc: kbuild-all(a)lists.01.org > Cc: gwml(a)vger.gnuweeb.org > Cc: linux-kernel(a)vger.kernel.org > Reported-by: kernel test robot > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp(a)intel.com > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc:= add PDMC driver") > Signed-off-by: Alviro Iskandar Setiawan Reviewed-by: Codrin Ciubotariu Thank you! --===============8043671622704997330==--