Received: from eggs.gnu.org ([2001:4830:134:3::10]:60304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vb1in-0002Oe-M1 for qemu-devel@nongnu.org; Tue, 29 Oct 2013 01:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vb1ii-0000p7-1l for qemu-devel@nongnu.org; Tue, 29 Oct 2013 01:20:05 -0400 Message-ID: <526F4571.7080807@weilnetz.de> Date: Tue, 29 Oct 2013 06:19:45 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1383021391-3152-1-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1383021391-3152-1-git-send-email-antonynpavlov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vl: fix build when configured with no graphic support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov , Anthony Liguori Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Am 29.10.2013 05:36, schrieb Antony Pavlov: > The following error occurs when building no graphic output support: > > vl.c: In function =E2=80=98main=E2=80=99: > vl.c:2829:19: error: variable =E2=80=98ds=E2=80=99 set but not used [= -Werror=3Dunused-but-set-variable] > DisplayState *ds; > ^ > cc1: all warnings being treated as errors > > To reproduce this issue, just run: > > $ ./configure \ > --disable-curses \ > --disable-sdl \ > --disable-cocoa \ > --disable-gtk \ > --disable-vnc \ > --enable-werror > $ make vl.o > > Signed-off-by: Antony Pavlov > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index b42ac67..8fbf25e 100644 > --- a/vl.c > +++ b/vl.c > @@ -4269,6 +4269,7 @@ int main(int argc, char **argv, char **envp) > /* init local displays */ > switch (display_type) { > case DT_NOGRAPHIC: > + (void)ds; > break; > #if defined(CONFIG_CURSES) > case DT_CURSES: Reviewed-by: Stefan Weil