From: "flichtenheld (Code Review)" Date: Fri, 8 Dec 2023 16:29:50 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <5273d762fe8bd0e65e019fa603bca948818672d1-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="903kLaIUJlI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: test_user_pass: Add UTs for character filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --903kLaIUJlI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=3Demail to review the following change. Change subject: test_user_pass: Add UTs for character filtering ...................................................................... test_user_pass: Add UTs for character filtering For simplicity I implemented them only with the inline method, but they actually apply to all methods. Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/473/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index edd566a..e468d3f 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -149,6 +149,29 @@ reset_user_pass(&up); + /* Test various valid characters */ + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + /* FIXME? content after first two lines just ignored */ + assert_true(get_user_pass_cr(&up, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B= =88=ED=8B=B0\n//ipassw=C3=B6rd!\nsome other content\nnot relevant", "UT", f= lags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B= =88=ED=8B=B0"); + assert_string_equal(up.password, "//ipassw=C3=B6rd!"); + + reset_user_pass(&up); + + /* Test various invalid characters */ + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + /*FIXME? allows arbitrary crap if c > 127 */ + /*FIXME? silently removes control characters */ + assert_true(get_user_pass_cr(&up, "\tiuser\r\nipass\xffwo\x1erd", "UT"= , flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + assert_string_equal(up.password, "ipass\xffword"); + + reset_user_pass(&up); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); will_return(query_user_exec_builtin, "cpassword"); will_return(query_user_exec_builtin, true); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db Gerrit-Change-Number: 473 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --903kLaIUJlI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

test_user_pass: Add UTs for character filtering

For si= mplicity I implemented them only with the
inline method, but they actual= ly apply to all methods.

Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1= afcb8c4db
Signed-off-by: Frank Lichtenheld <frank@...2641...>
-= --
M tests/unit_tests/openvpn/test_user_pass.c
1 file changed, 23 ins= ertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:2941=
8/openvpn refs/changes/73/473/1
diff --git a/tests/unit_tests/openv=
pn/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c
<= span>index edd566a..e468d3f 100644
--- a/tests/unit_tests/o= penvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test= _user_pass.c
@@ -149,6 +149,29 @@
<= br> reset_user_pass(&up);

+ /* Test various valid characters = */
+ /*FIXME: quer= y_user_exec() called even though nothing queued */
+ will_return(query_user_exec_builtin, tru= e);
+ /* FIXME? co= ntent after first two lines just ignored */
+ assert_true(get_user_pass_cr(&up, "#iu= ser and =EC=BB=A4=EB=AE=A4=EB=8B=88=ED=8B=B0\n//ipassw=C3=B6rd!\nsome other= content\nnot relevant", "UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(u= p.username, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=88=ED=8B=B0");
+ assert_string_equ= al(up.password, "//ipassw=C3=B6rd!");
+
+ reset_user_pass(&up);
+
+= /* Test various invalid characters */
+ /*FIXME: query_user_exec() called even though not= hing queued */
+ w= ill_return(query_user_exec_builtin, true);
+ /*FIXME? allows arbitrary crap if c > 127 */<= /span>
+ /*FIXME? silentl= y removes control characters */
+ assert_true(get_user_pass_cr(&up, "\tiuser\r\nipas= s\xffwo\x1erd", "UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.usern= ame, "iuser");

+ assert_string_equal(up.password, "ipass\xffword");
+
+ reset_user_pass(&up);
+

expect_strin= g(query_user_exec_builtin, query_user[i].prompt, "Enter UT Password:&q= uot;);
will_return(query_user_exec_builtin, "cpas= sword");
will_return(query_user_exec_builtin, tru= e);

To view, visit change 473. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e= 2ca1afcb8c4db
Gerrit-Change-Number: 473
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--903kLaIUJlI=--