Received: from eggs.gnu.org ([2001:4830:134:3::10]:40900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdzI3-0003wS-QM for qemu-devel@nongnu.org; Wed, 06 Nov 2013 04:20:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdzHx-0002w8-Qf for qemu-devel@nongnu.org; Wed, 06 Nov 2013 04:20:43 -0500 Message-ID: <527A09E4.7090605@msgid.tls.msk.ru> Date: Wed, 06 Nov 2013 13:20:36 +0400 From: Michael Tokarev MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qga: Fix shutdown command of guest agent to work with SysV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: whitearchey Cc: qemu-trivial@nongnu.org, qemu-devel 06.11.2013 05:54, whitearchey wrote: > For now guest agent uses following command to shutdown system: > shutdown -P +0 "blabla" > but this syntax works only with shutdown command from systemd or upstart, > because SysV shutdown requires -h switch. > > Following patch changes the command so it works with systemd, upstart and SysV While the patch is one-liner indeed, it is a bit more than trivial. Because it changes things in a non-obvious way, especially when multiple systems are concerned. Cc'ing qemu-devel@ due to this. > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > - execle("/sbin/shutdown", "shutdown", shutdown_flag, "+0", > + execle("/sbin/shutdown", "shutdown", "-h", shutdown_flag, "+0", Note that shutdown command is not in POSIX, despite the fact that this is put into commands-posix.c Note also that even shutdown from sysvinit on linux has another option, -P, which mean poweroff, while -h means "halt OR poweroff" (the latter is a bit unclear). Does the same work on other *nixes? *BSD? Solaris? Thanks, /mjt