From: "ordex (Code Review)" Date: Tue, 22 Jul 2025 20:22:25 +0000 References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <528fcbd375f795e7a8243611e8ee0eb899477c3c-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="kySUSV1ORgM="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: dco_linux: factor out netlink notification code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --kySUSV1ORgM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1099?usp=3Demail to review the following change. Change subject: dco_linux: factor out netlink notification code ...................................................................... dco_linux: factor out netlink notification code ovpn_handle_msg() is soon becoming the main entry point for parsing *all* incoming netlink messages. For this reason it is essential that this function is kept simple and slim. Move all code parsing netlink multicast notifications to their own helpers and then invoke them. This patch does not introduce any functional change. It is intended in preparation for extending ovpn_handle_msg() to become a genering netlink message parser. Change-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461 Signed-off-by: Antonio Quartulli --- M src/openvpn/dco_linux.c 1 file changed, 150 insertions(+), 111 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1099/1 diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index ec6efaa..0a22879 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -956,6 +956,153 @@ return NL_OK; } +static int +ovpn_handle_peer_del_ntf(dco_context_t *dco, struct nlattr *attrs[]) +{ + /* we must know which interface this message is referring to in order = to + * avoid mixing messages for other instances + */ + if (!attrs[OVPN_A_IFINDEX]) + { + msg(D_DCO, "ovpn-dco: Received message without ifindex"); + return NL_STOP; + } + + if (!attrs[OVPN_A_PEER]) + { + msg(D_DCO, "ovpn-dco: no peer in PEER_DEL_NTF message"); + return NL_STOP; + } + + struct nlattr *dp_attrs[OVPN_A_PEER_MAX + 1]; + if (nla_parse_nested(dp_attrs, OVPN_A_PEER_MAX, attrs[OVPN_A_PEER], + NULL)) + { + msg(D_DCO, "ovpn-dco: can't parse peer in PEER_DEL_NTF messsage"); + return NL_STOP; + } + + if (!dp_attrs[OVPN_A_PEER_DEL_REASON]) + { + msg(D_DCO, "ovpn-dco: no reason in PEER_DEL_NTF message"); + return NL_STOP; + } + if (!dp_attrs[OVPN_A_PEER_ID]) + { + msg(D_DCO, "ovpn-dco: no peer-id in PEER_DEL_NTF message"); + return NL_STOP; + } + + int reason =3D nla_get_u32(dp_attrs[OVPN_A_PEER_DEL_REASON]); + unsigned int peerid =3D nla_get_u32(dp_attrs[OVPN_A_PEER_ID]); + + msg(D_DCO_DEBUG, "ovpn-dco: received CMD_PEER_DEL_NTF, ifindex: %d, pe= er-id %u, reason: %d", + dco->ifindex, peerid, reason); + dco->dco_message_peer_id =3D peerid; + dco->dco_del_peer_reason =3D reason; + dco->dco_message_type =3D OVPN_CMD_PEER_DEL_NTF; + + return NL_OK; +} + +static int +ovpn_handle_peer_float_ntf(dco_context_t *dco, struct nlattr *attrs[]) +{ + /* we must know which interface this message is referring to in order = to + * avoid mixing messages for other instances + */ + if (!attrs[OVPN_A_IFINDEX]) + { + msg(D_DCO, "ovpn-dco: Received message without ifindex"); + return NL_STOP; + } + + if (!attrs[OVPN_A_PEER]) + { + msg(D_DCO, "ovpn-dco: no peer in PEER_FLOAT_NTF message"); + return NL_STOP; + } + + struct nlattr *fp_attrs[OVPN_A_PEER_MAX + 1]; + if (nla_parse_nested(fp_attrs, OVPN_A_PEER_MAX, attrs[OVPN_A_PEER], + NULL)) + { + msg(D_DCO, "ovpn-dco: can't parse peer in PEER_FLOAT_NTF messsage"= ); + return NL_STOP; + } + + if (!fp_attrs[OVPN_A_PEER_ID]) + { + msg(D_DCO, "ovpn-dco: no peer-id in PEER_FLOAT_NTF message"); + return NL_STOP; + } + uint32_t peerid =3D nla_get_u32(fp_attrs[OVPN_A_PEER_ID]); + + if (!ovpn_parse_float_addr(fp_attrs, (struct sockaddr *)&dco->dco_floa= t_peer_ss)) + { + return NL_STOP; + } + + struct gc_arena gc =3D gc_new(); + msg(D_DCO_DEBUG, + "ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: %u, peer-id %u, a= ddress: %s", + dco->ifindex, peerid, print_sockaddr((struct sockaddr *)&dco->dco_= float_peer_ss, &gc)); + dco->dco_message_peer_id =3D (int)peerid; + dco->dco_message_type =3D OVPN_CMD_PEER_FLOAT_NTF; + + gc_free(&gc); + + return NL_OK; +} + +static int +ovpn_handle_key_swap_ntf(dco_context_t *dco, struct nlattr *attrs[]) +{ + /* we must know which interface this message is referring to in order = to + * avoid mixing messages for other instances + */ + if (!attrs[OVPN_A_IFINDEX]) + { + msg(D_DCO, "ovpn-dco: Received message without ifindex"); + return NL_STOP; + } + + if (!attrs[OVPN_A_KEYCONF]) + { + msg(D_DCO, "ovpn-dco: no keyconf in KEY_SWAP_NTF message"); + return NL_STOP; + } + + struct nlattr *dp_attrs[OVPN_A_KEYCONF_MAX + 1]; + if (nla_parse_nested(dp_attrs, OVPN_A_KEYCONF_MAX, + attrs[OVPN_A_KEYCONF], NULL)) + { + msg(D_DCO, "ovpn-dco: can't parse keyconf in KEY_SWAP_NTF message"= ); + return NL_STOP; + } + if (!dp_attrs[OVPN_A_KEYCONF_PEER_ID]) + { + msg(D_DCO, "ovpn-dco: no peer-id in KEY_SWAP_NTF message"); + return NL_STOP; + } + if (!dp_attrs[OVPN_A_KEYCONF_KEY_ID]) + { + msg(D_DCO, "ovpn-dco: no key-id in KEY_SWAP_NTF message"); + return NL_STOP; + } + + int key_id =3D nla_get_u16(dp_attrs[OVPN_A_KEYCONF_KEY_ID]); + unsigned int peer_id =3D nla_get_u32(dp_attrs[OVPN_A_KEYCONF_PEER_ID]); + + msg(D_DCO_DEBUG, "ovpn-dco: received CMD_KEY_SWAP_NTF, ifindex: %d, pe= er-id %u, key-id: %d", + dco->ifindex, peer_id, key_id); + dco->dco_message_peer_id =3D peer_id; + dco->dco_message_key_id =3D key_id; + dco->dco_message_type =3D OVPN_CMD_KEY_SWAP_NTF; + + return NL_OK; +} + /* This function parses any netlink message sent by ovpn-dco to userspace = */ static int ovpn_handle_msg(struct nl_msg *msg, void *arg) @@ -979,15 +1126,6 @@ return NL_STOP; } - /* we must know which interface this message is referring to in order = to - * avoid mixing messages for other instances - */ - if (!attrs[OVPN_A_IFINDEX]) - { - msg(D_DCO, "ovpn-dco: Received message without ifindex"); - return NL_STOP; - } - uint32_t ifindex =3D nla_get_u32(attrs[OVPN_A_IFINDEX]); if (ifindex !=3D dco->ifindex) { @@ -1008,116 +1146,17 @@ { case OVPN_CMD_PEER_DEL_NTF: { - if (!attrs[OVPN_A_PEER]) - { - msg(D_DCO, "ovpn-dco: no peer in PEER_DEL_NTF message"); - return NL_STOP; - } - - struct nlattr *dp_attrs[OVPN_A_PEER_MAX + 1]; - if (nla_parse_nested(dp_attrs, OVPN_A_PEER_MAX, attrs[OVPN_A_P= EER], - NULL)) - { - msg(D_DCO, "ovpn-dco: can't parse peer in PEER_DEL_NTF mes= ssage"); - return NL_STOP; - } - - if (!dp_attrs[OVPN_A_PEER_DEL_REASON]) - { - msg(D_DCO, "ovpn-dco: no reason in PEER_DEL_NTF message"); - return NL_STOP; - } - if (!dp_attrs[OVPN_A_PEER_ID]) - { - msg(D_DCO, "ovpn-dco: no peer-id in PEER_DEL_NTF message"); - return NL_STOP; - } - - int reason =3D nla_get_u32(dp_attrs[OVPN_A_PEER_DEL_REASON]); - unsigned int peerid =3D nla_get_u32(dp_attrs[OVPN_A_PEER_ID]); - - msg(D_DCO_DEBUG, "ovpn-dco: received CMD_PEER_DEL_NTF, ifindex= : %d, peer-id %u, reason: %d", - ifindex, peerid, reason); - dco->dco_message_peer_id =3D peerid; - dco->dco_del_peer_reason =3D reason; - dco->dco_message_type =3D OVPN_CMD_PEER_DEL_NTF; - break; + return ovpn_handle_peer_del_ntf(dco, attrs); } case OVPN_CMD_PEER_FLOAT_NTF: { - if (!attrs[OVPN_A_PEER]) - { - msg(D_DCO, "ovpn-dco: no peer in PEER_FLOAT_NTF message"); - return NL_STOP; - } - - struct nlattr *fp_attrs[OVPN_A_PEER_MAX + 1]; - if (nla_parse_nested(fp_attrs, OVPN_A_PEER_MAX, attrs[OVPN_A_P= EER], - NULL)) - { - msg(D_DCO, "ovpn-dco: can't parse peer in PEER_FLOAT_NTF m= esssage"); - return NL_STOP; - } - - if (!fp_attrs[OVPN_A_PEER_ID]) - { - msg(D_DCO, "ovpn-dco: no peer-id in PEER_FLOAT_NTF message= "); - return NL_STOP; - } - uint32_t peerid =3D nla_get_u32(fp_attrs[OVPN_A_PEER_ID]); - - if (!ovpn_parse_float_addr(fp_attrs, (struct sockaddr *)&dco->= dco_float_peer_ss)) - { - return NL_STOP; - } - - struct gc_arena gc =3D gc_new(); - msg(D_DCO_DEBUG, - "ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: %u, peer-= id %u, address: %s", - ifindex, peerid, print_sockaddr((struct sockaddr *)&dco->d= co_float_peer_ss, &gc)); - dco->dco_message_peer_id =3D (int)peerid; - dco->dco_message_type =3D OVPN_CMD_PEER_FLOAT_NTF; - - gc_free(&gc); - break; + return ovpn_handle_peer_float_ntf(dco, attrs); } case OVPN_CMD_KEY_SWAP_NTF: { - if (!attrs[OVPN_A_KEYCONF]) - { - msg(D_DCO, "ovpn-dco: no keyconf in KEY_SWAP_NTF message"); - return NL_STOP; - } - - struct nlattr *dp_attrs[OVPN_A_KEYCONF_MAX + 1]; - if (nla_parse_nested(dp_attrs, OVPN_A_KEYCONF_MAX, - attrs[OVPN_A_KEYCONF], NULL)) - { - msg(D_DCO, "ovpn-dco: can't parse keyconf in KEY_SWAP_NTF = message"); - return NL_STOP; - } - if (!dp_attrs[OVPN_A_KEYCONF_PEER_ID]) - { - msg(D_DCO, "ovpn-dco: no peer-id in KEY_SWAP_NTF message"); - return NL_STOP; - } - if (!dp_attrs[OVPN_A_KEYCONF_KEY_ID]) - { - msg(D_DCO, "ovpn-dco: no key-id in KEY_SWAP_NTF message"); - return NL_STOP; - } - - int key_id =3D nla_get_u16(dp_attrs[OVPN_A_KEYCONF_KEY_ID]); - unsigned int peer_id =3D nla_get_u32(dp_attrs[OVPN_A_KEYCONF_P= EER_ID]); - - msg(D_DCO_DEBUG, "ovpn-dco: received CMD_KEY_SWAP_NTF, ifindex= : %d, peer-id %u, key-id: %d", - ifindex, peer_id, key_id); - dco->dco_message_peer_id =3D peer_id; - dco->dco_message_key_id =3D key_id; - dco->dco_message_type =3D OVPN_CMD_KEY_SWAP_NTF; - break; + return ovpn_handle_key_swap_ntf(dco, attrs); } default: -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1099?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461 Gerrit-Change-Number: 1099 Gerrit-PatchSet: 1 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --kySUSV1ORgM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

ordex would like plaisthos and flichtenheld to review t= his change.

V= iew Change

dco_linux: factor out netlink notification code

ovpn_= handle_msg() is soon becoming the main entry point for parsing
*all* inc= oming netlink messages. For this reason it is essential
that this functi= on is kept simple and slim.

Move all code parsing netlink multicast = notifications to their own
helpers and then invoke them.

This pat= ch does not introduce any functional change.
It is intended in preparati= on for extending ovpn_handle_msg() to
become a genering netlink message = parser.

Change-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461
Sign= ed-off-by: Antonio Quartulli <antonio@...2726...>
---
M src/ope= nvpn/dco_linux.c
1 file changed, 150 insertions(+), 111 deletions(-)
=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1099=
/1
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c
index ec6efaa..0a22879 100644
--- a/src/open= vpn/dco_linux.c
+++ b/src/openvpn/dco_linux.c
@@ -956,6 +956,153 @@

return NL_OK;
}

+static int
+ovpn_ha= ndle_peer_del_ntf(dco_context_t *dco, struct nlattr *attrs[])
+{
+ /* we must know which interface this message is= referring to in order to
+ * avoid mixing messages for other instances
+ */
+ if (!attrs[OVPN_A_IFINDEX])
+ {
+ msg(D_DCO, "ovpn-dco: Received message wi= thout ifindex");
+ return NL_STOP;
+ }
+<= br>+ if (!attrs[OVPN_A_PEER]= )
+ {
+ msg(D_DCO, "ovpn-dc= o: no peer in PEER_DEL_NTF message");
+ return NL_STOP;
+ }
+
+ st= ruct nlattr *dp_attrs[OVPN_A_PEER_MAX + 1];
+ if (nla_parse_nested(dp_attrs, OVPN_A_PEER_MAX,= attrs[OVPN_A_PEER],
= + NULL))
+ {
+ = msg(D_DCO, "ovpn-dco: can't parse peer in PEER_DEL_NTF mess= sage");
+ = return NL_STOP;
+ = }
+
+ if (!dp_attrs[OVPN_A_PEER_DEL_RE= ASON])
+ {<= br>+ msg(D_DCO, "ov= pn-dco: no reason in PEER_DEL_NTF message");
+ return NL_STOP;
+ }
+ if (!dp_attrs[OVPN_A_PEER_ID])
+ {
+ msg(D_DCO, "ovpn-dco: no peer-id in PEER_= DEL_NTF message");
+ return NL_STOP;
+ }
+

+ int reason =3D nla_ge= t_u32(dp_attrs[OVPN_A_PEER_DEL_REASON]);
+ unsigned int peerid =3D nla_get_u32(dp_attrs[OVPN_= A_PEER_ID]);
+=
+ msg(D_DCO_DEBUG, "= ;ovpn-dco: received CMD_PEER_DEL_NTF, ifindex: %d, peer-id %u, reason: %d&q= uot;,
+ dco-&g= t;ifindex, peerid, reason);
+ dco->dco_message_peer_id =3D peerid;
+ dco->dco_del_peer_reason =3D reaso= n;
+ dco->dco_m= essage_type =3D OVPN_CMD_PEER_DEL_NTF;
+
+= return NL_OK;
+}<= /span>
+
+static int
+ovpn_handle_peer_float_ntf(dco_context_t *dco, s= truct nlattr *attrs[])
+ /* we must = know which interface this message is referring to in order to
+ * avoid mixing messages for = other instances

+ = */
+ if (!attrs[O= VPN_A_IFINDEX])
+ = {
+ msg(D_DCO,= "ovpn-dco: Received message without ifindex");
+ return NL_STOP;
+ }
+
+ if (!attrs[OVPN_A_PEER])
+ {
+ msg(D_DCO, "ovpn-dco: no peer in PEER_FLOAT_NTF message&qu= ot;);
+ return= NL_STOP;
+ }
+
+ struct nlattr *fp_attrs[OVPN_A_PEER_M= AX + 1];
+ if (nla= _parse_nested(fp_attrs, OVPN_A_PEER_MAX, attrs[OVPN_A_PEER],
+ NULL))
+ {
+ msg(D_DCO, "ovpn-dco: c= an't parse peer in PEER_FLOAT_NTF messsage");
+ return NL_STOP;
+ }
+
+ if (!fp_attrs[OVPN_A_PEER_ID])
+ {
+ msg(D_DCO, "ovpn-dco: no peer-id in PEER_FLOAT_NTF mess= age");
+ = return NL_STOP;
+ = }
+ uint32_t peeri= d =3D nla_get_u32(fp_attrs[OVPN_A_PEER_ID]);
+
+ if (!ovpn_parse_float_addr(fp_attrs, (struct sockaddr *)&dco-= >dco_float_peer_ss))
+ {
+ re= turn NL_STOP;
+ }<= /span>
+
+ struct gc_arena gc =3D gc_new();
+ msg(D_DCO_DEBUG,
+ "ovpn-dc= o: received CMD_PEER_FLOAT_NTF, ifindex: %u, peer-id %u, address: %s",=
+ dco->ifi= ndex, peerid, print_sockaddr((struct sockaddr *)&dco->dco_float_peer= _ss, &gc));
+ = dco->dco_message_peer_id =3D (int)peerid;
+ dco->dco_message_type =3D OVPN_CMD_PEER_FLO= AT_NTF;
+
<= span style=3D"color: hsl(120, 100%, 40%);">+ gc_free(&gc);
+
+ return NL_OK;
+}
+
+static int
+ovpn_handle_key_swap_= ntf(dco_context_t *dco, struct nlattr *attrs[])
+{
+ /* we must know which interface this message is referring to = in order to
+ * a= void mixing messages for other instances
+ */
+ if (!attrs[OVPN_A_IFINDEX])
+ {
+ msg(D_DCO, "ovpn-dco: Received message without ifindex&= quot;);
+ retu= rn NL_STOP;
+ }
+
+ if (!attrs[OVPN_A_KEYCONF])+ {
+ msg(D_DCO, "ovpn-dco: no key= conf in KEY_SWAP_NTF message");
+ return NL_STOP;
+ }
+
+ struct n= lattr *dp_attrs[OVPN_A_KEYCONF_MAX + 1];
+ if (nla_parse_nested(dp_attrs, OVPN_A_KEYCONF_MAX,=
+ = attrs[OVPN_A_KEYCONF], NULL))
+ {
+ msg(D_DCO, "ovpn-dco: can't parse keyconf in KEY_SWAP_NT= F message");
+ = return NL_STOP;
+ }
+ if (!dp_= attrs[OVPN_A_KEYCONF_PEER_ID])
+ {
+ = msg(D_DCO, "ovpn-dco: no peer-id in KEY_SWAP_NTF message");<= /span>
+ return NL_ST= OP;
+ }
= + if (!dp_attrs[OVPN_A_KEYCO= NF_KEY_ID])
+ {
+ msg(D_DCO, &qu= ot;ovpn-dco: no key-id in KEY_SWAP_NTF message");
+ return NL_STOP;
+ }
+
+ int key_id =3D nla_get_u16(dp_attrs[OVPN_A_KEYCONF_KEY_ID]);

+ unsigned int peer_id= =3D nla_get_u32(dp_attrs[OVPN_A_KEYCONF_PEER_ID]);
+
+ msg(D_DCO_DEBUG, "ovpn-dco: received CMD_KEY_SWAP_N= TF, ifindex: %d, peer-id %u, key-id: %d",
+ dco->ifindex, peer_id, key_id);
+ dco->dco_message_p= eer_id =3D peer_id;
+= dco->dco_message_key_id =3D key_id;
+ dco->dco_message_type =3D OVPN_CMD_KEY_SWAP_N= TF;
+
+ return NL_OK;

+}
+
/* This function parses any netlink m= essage sent by ovpn-dco to userspace */
static int<= br> ovpn_handle_msg(struct nl_msg *msg, void *arg)
@@= -979,15 +1126,6 @@
return NL_STOP;
}


- /* we must know which interface this message is referring to in or= der to
- * avoid mi= xing messages for other instances
- */
- = if (!attrs[OVPN_A_IFINDEX])
- {
- = msg(D_DCO, "ovpn-dco: Received message without ifindex");<= br>- return NL_STOP;
- }
-
uint32_t ifindex =3D = nla_get_u32(attrs[OVPN_A_IFINDEX]);
if (ifindex !=3D d= co->ifindex)
{
@@ -1008,116 +1146,1= 7 @@
{
case OVPN_CMD_PEER_DEL= _NTF:
{
- if (!attrs[OVPN_A_PEER])
- {
- msg(D_DCO, "ovpn-dco: no peer in PEE= R_DEL_NTF message");
- return NL_STOP;
- }
-
- str= uct nlattr *dp_attrs[OVPN_A_PEER_MAX + 1];
- if (nla_parse_nested(dp_attrs, OVPN_A_PEER= _MAX, attrs[OVPN_A_PEER],
- NULL))
- {
- msg(D_DCO, "ovpn-dco: can't parse pe= er in PEER_DEL_NTF messsage");
- return NL_STOP;
- }
-
- = if (!dp_attrs[OVPN_A_PEER_DEL_REASON])
- {
- msg(D_DCO, "ovpn-dco: no reason in PEE= R_DEL_NTF message");
- return NL_STOP;
- }
- if (!dp_attrs[OVPN_A_PEER_ID])
- {
- msg(D_DCO, "ovpn-dco: no peer-id in= PEER_DEL_NTF message");
- return NL_STOP;
- }
-
- = int reason =3D nla_get_u32(dp_attrs[OVPN_A_PEER_DEL_REASON]);
- unsigned int peerid = =3D nla_get_u32(dp_attrs[OVPN_A_PEER_ID]);

-
-= msg(D_DCO_DEBUG, "ovpn-dco: received CMD_PEER_DEL_NTF, ifi= ndex: %d, peer-id %u, reason: %d",
- ifindex, peerid, reason);
- dco->dco_message_peer_= id =3D peerid;
- = dco->dco_del_peer_reason =3D reason;
- dco->dco_message_type =3D OVPN_CMD_PE= ER_DEL_NTF;
- = break;
+ = return ovpn_handle_peer_del_ntf(dco, attrs);
}

case OVPN_CMD_PEER_FLOAT_NTF:
{
= - if (!attrs[OVPN_A_PEER])
- {
- msg(D_DCO, "ovpn-dco: no peer in PEER_FLOAT_NT= F message");
- = return NL_STOP;
- }
-
- struct nlat= tr *fp_attrs[OVPN_A_PEER_MAX + 1];
- if (nla_parse_nested(fp_attrs, OVPN_A_PEER_MAX, at= trs[OVPN_A_PEER],
- = NULL))
- {
- msg(D_DCO, "ovpn-dco: can't parse peer in PE= ER_FLOAT_NTF messsage");
- return NL_STOP;
- }
-
- = if (!fp_attrs[OVPN_A_PEER_ID])
- {
- msg(D_DCO, "ovpn-dco: no peer-id in PEER_FLOAT_NTF m= essage");
- = return NL_STOP;
- = uint32_t peerid =3D nla_get_u32(fp_attrs[OVPN_A_PEER_ID]);-
- if (!ovpn_parse_float_addr(fp_attrs, (st= ruct sockaddr *)&dco->dco_float_peer_ss))
- {
- return NL_STOP;
- }
-
-= struct gc_arena gc =3D gc_new();
- msg(D_DCO_DEBUG,
- "ovpn-dco: received CM= D_PEER_FLOAT_NTF, ifindex: %u, peer-id %u, address: %s",
- ifindex, peerid, pr= int_sockaddr((struct sockaddr *)&dco->dco_float_peer_ss, &gc));<= /span>
- dco->dc= o_message_peer_id =3D (int)peerid;
- dco->dco_message_type =3D OVPN_CMD_PEER_FLOAT_N= TF;
-
- gc_free(&gc);- break;
+ return ovpn_handle_p= eer_float_ntf(dco, attrs);

}

case OVPN_CMD_KEY_SWAP_NTF:
= {
- if (!att= rs[OVPN_A_KEYCONF])
- = {
- = msg(D_DCO, "ovpn-dco: no keyconf in KEY_SWAP_NTF message");=
- retur= n NL_STOP;
- = }
-
- struct nlattr *dp_attrs[OVPN= _A_KEYCONF_MAX + 1];
- = if (nla_parse_nested(dp_attrs, OVPN_A_KEYCONF_MAX,
- at= trs[OVPN_A_KEYCONF], NULL))
- {
- = msg(D_DCO, "ovpn-dco: can't parse keyconf in KEY_SWA= P_NTF message");
-= return NL_STOP;
- }
- if (!dp_attrs[OVPN_A_KEYCONF_PEER_ID])
- {
- msg(D_DCO, "ovpn-dco: no peer-= id in KEY_SWAP_NTF message");
- return NL_STOP;
- }
- if (!dp_attrs[OVPN_A_KEYCONF_KEY_ID])
= - {
- msg(D_DCO, "ovpn-dc= o: no key-id in KEY_SWAP_NTF message");
- return NL_STOP;
- }
-
- int key_id =3D nla_get_u16(dp_attrs[OVPN_A_KEYCONF_KEY_ID])= ;
- unsigned= int peer_id =3D nla_get_u32(dp_attrs[OVPN_A_KEYCONF_PEER_ID]);
<= span style=3D"color: hsl(0, 100%, 40%);">-
- msg(D_DCO_DEBUG, "ovpn-dco: received = CMD_KEY_SWAP_NTF, ifindex: %d, peer-id %u, key-id: %d",
- ifindex, peer_id, ke= y_id);
- dco= ->dco_message_peer_id =3D peer_id;
- dco->dco_message_key_id =3D key_id;- dco->dco_messag= e_type =3D OVPN_CMD_KEY_SWAP_NTF;
- break;
+ return ovpn_handle_key_swap_ntf(dco, attrs);<= br> }

default:


To view, visit change 1099. To unsubscribe, or= for help writing mail filters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7bbc40b7b66f6e0512cd2cf9791= 766bcc4970461
Gerrit-Change-Number: 1099
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--kySUSV1ORgM=--