From: Fabio Fantoni Subject: Re: [PATCH 0/2] Handle xen_platform_pci=0 case Date: Mon, 25 Nov 2013 10:04:59 +0100 Message-ID: <529312BB.7050003@m2r.biz> References: <1385133191-23033-1-git-send-email-anthony.perard@citrix.com> <528F7CF2.6000407@m2r.biz> <20131122165450.GB10855@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131122165450.GB10855@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Anthony PERARD Cc: George Dunlap , Ian Jackson , Stefano Stabellini , Ian Campbell , Xen Devel List-Id: xen-devel@lists.xenproject.org Il 22/11/2013 17:54, Anthony PERARD ha scritto: > On Fri, Nov 22, 2013 at 04:49:06PM +0100, Fabio Fantoni wrote: >> Il 22/11/2013 16:13, Anthony PERARD ha scritto: >>> Hi, >>> >>> Here is a little series that attempt to fix the issue regarding >>> xen_platform_pci=0 not been handled. >>> >>> There are two patches, the first one adds an option to specifies the QEMU >>> machine that a user wants and we handle the xen_platform_pci=0 case using the >>> new option. >>> >>> The new options "qemu_machine_override" will help if one want to try a q35 >>> based device model. Otherwise, it will be used by libxl to switch to the "pc" >>> machine instead of the "xenfv" one when necessary, as the only difference >>> between both (since QEMU 1.6) is the presence of the xen-platform pci device. About q35 in theory should be missing only the implementation in hvmloader, is there a draft somewhere to try or to should be made? >>> >>> Regards, >>> >>> Anthony PERARD (2): >>> libxl: adding support to use -machine option of QEMU. >>> libxl: Handle xen_platform_pci=0 case with qemu-xen. >>> >>> tools/libxl/libxl_dm.c | 31 +++++++++++++++++++++++++++++-- >>> tools/libxl/libxl_types.idl | 1 + >>> tools/libxl/xl_cmdimpl.c | 3 +++ >>> 3 files changed, 33 insertions(+), 2 deletions(-) >>> >> Tested with upstream qemu 1.6 from staging: >> vi Config.mk >> QEMU_UPSTREAM_URL ?= >> git://xenbits.xen.org/staging/qemu-upstream-unstable.git >> QEMU_UPSTREAM_REVISION ?= master >> >> With xen_platform_pci=0 Fedora19 hvm domU gave me kernel panic on boot. >> xl create -vvv, xl dmesg and serial domUs boot (with calltrace) logs on >> attachments. >> >> With xen_platform_pci=1 boot correctly. >> >> > >> [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-3.11.6-200.fc19.x86_64 root=/d >> ev/mapper/fedora-root ro rd.lvm.lv=fedora/swap rd.md=0 rd.dm=0 rd.luks=0 vconso >> le.font=latarcyrheb-sun16 rd.lvm.lv=fedora/root vconsole.keymap=it2 rhgb debug >> console=hvc0 console=ttyS0 LANG=it_IT.UTF-8 > [...] >> [ 1.575205] scsi 0:0:0:0: Direct-Access ATA QEMU HARDDISK 1.6. P >> Q: 0 ANSI: 5 >> [ 1.575328] sd 0:0:0:0: Attached scsi generic sg0 type 0 >> [ 1.575381] sd 0:0:0:0: [sda] 20480000 512-byte logical blocks: (10.4 GB/9.7 >> 6 GiB) >> [ 1.575427] sd 0:0:0:0: [sda] Write Protect is off >> [ 1.575429] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00 >> [ 1.575445] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doe >> sn't support DPO or FUA >> [ 1.661471] sda: sda1 sda2 >> [ 1.665373] ------------[ cut here ]------------ >> [ 1.665704] sd 0:0:0:0: [sda] Attached SCSI disk >> [ 1.666342] kernel BUG at drivers/xen/grant-table.c:1189! >> [ 1.666342] invalid opcode: 0000 [#1] SMP >> [ 1.666342] Modules linked in: >> [ 1.666342] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.11.6-200.fc19.x86_64 >> #1 >> [ 1.666342] Hardware name: Xen HVM domU, BIOS 4.4-unstable 11/22/2013 >> [ 1.666342] task: ffff88007a7b0000 ti: ffff88007a7b8000 task.ti: ffff88007a7 >> b8000 >> [ 1.666342] RIP: 0010:[] [] get_free_en >> tries+0x2cf/0x2e0 >> [ 1.666342] RSP: 0000:ffff88007a7b9bd8 EFLAGS: 00010046 >> [ 1.666342] RAX: 0000000000000286 RBX: 0000000000000001 RCX: 000000000000000 >> 0 >> [ 1.666342] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff81fc7d7 >> 0 >> [ 1.666342] RBP: ffff88007a7b9c20 R08: 0000000000000000 R09: 000000000000fff >> c >> [ 1.666342] R10: 0000000000000000 R11: 0000000000000000 R12: 000000000000028 >> 6 >> [ 1.666342] R13: 0000000000037032 R14: 0000000000000000 R15: 000000000000000 >> 0 >> [ 1.666342] FS: 0000000000000000(0000) GS:ffff88007b600000(0000) knlGS:0000 >> 000000000000 >> [ 1.666342] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b >> [ 1.666342] CR2: 0000000000000000 CR3: 0000000001c0c000 CR4: 00000000000006f >> 0 >> [ 1.666342] Stack: >> [ 1.666342] ffff8800370174b0 ffff880037017408 ffff88007a7b9c20 00000001814b >> 68b6 >> [ 1.666342] ffff880037024600 0000000000000000 0000000000037032 000000000000 >> 0000 >> [ 1.666342] 0000000000000000 ffff88007a7b9c50 ffffffff813a0c43 ffff88003702 >> 4600 >> [ 1.666342] Call Trace: >> [ 1.666342] [] gnttab_grant_foreign_access+0x23/0x60 >> [ 1.666342] [] xenkbd_connect_backend+0x58/0x2c0 >> [ 1.666342] [] xenkbd_probe+0x2fa/0x340 >> [ 1.666342] [] xenbus_dev_probe+0x8e/0x170 >> [ 1.666342] [] xenbus_frontend_dev_probe+0x48/0x50 >> [ 1.666342] [] driver_probe_device+0x87/0x390 >> [ 1.666342] [] __driver_attach+0x93/0xa0 >> [ 1.666342] [] ? __device_attach+0x40/0x40 >> [ 1.666342] [] bus_for_each_dev+0x63/0xa0 >> [ 1.666342] [] driver_attach+0x1e/0x20 >> [ 1.666342] [] bus_add_driver+0x1e8/0x2a0 >> [ 1.666342] [] ? lifebook_module_init+0x1b/0x1b >> [ 1.666342] [] driver_register+0x74/0x150 >> [ 1.666342] [] ? lifebook_module_init+0x1b/0x1b >> [ 1.666342] [] xenbus_register_driver_common+0x1a/0x20 >> [ 1.666342] [] xenbus_register_frontend+0x28/0x50 >> [ 1.666342] [] xenkbd_init+0x2b/0x34 >> [ 1.666342] [] do_one_initcall+0xfa/0x1b0 >> [ 1.666342] [] ? parse_args+0x225/0x400 >> [ 1.666342] [] kernel_init_freeable+0x177/0x1ff >> [ 1.666342] [] ? do_early_param+0x88/0x88 >> [ 1.666342] [] ? rest_init+0x80/0x80 >> [ 1.666342] [] kernel_init+0xe/0x190 >> [ 1.666342] [] ret_from_fork+0x7c/0xb0 >> [ 1.666342] [] ? rest_init+0x80/0x80 >> [ 1.666342] Code: 8b 05 9e 71 c2 00 44 8b 2d 83 71 c2 00 e9 62 fe ff ff 66 2 >> e 0f 1f 84 00 00 00 00 00 b8 e4 ff ff ff e9 2a ff ff ff 44 89 c7 eb 84 <0f> 0b >> 0f 0b 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 >> [ 1.666342] RIP [] get_free_entries+0x2cf/0x2e0 >> [ 1.666342] RSP >> [ 1.666342] ---[ end trace 6eb44b05748c7d42 ]--- >> [ 2.122137] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0 >> 000000b > Looks like I have a similaire issue with the module xen_kbdfront, but > later in the boot, an the guest is running fine. I think that could be > an hidden bug which did not show up before, I'll try to understand the > issue. > > Thank you for testing. > If you need more tests and/or informations tell me and I'll do and post them.