From: "H. Peter Anvin" Subject: Re: [PATCH v6 4/5] MCS Lock: Barrier corrections Date: Mon, 25 Nov 2013 10:52:10 -0800 Message-ID: <52939C5A.3070208@zytor.com> References: <20131120171400.GI4138@linux.vnet.ibm.com> <20131121110308.GC10022@twins.programming.kicks-ass.net> <20131121125616.GI3694@twins.programming.kicks-ass.net> <20131121132041.GS4138@linux.vnet.ibm.com> <20131121172558.GA27927@linux.vnet.ibm.com> <20131121215249.GZ16796@laptop.programming.kicks-ass.net> <20131121221859.GH4138@linux.vnet.ibm.com> <20131122155835.GR3866@twins.programming.kicks-ass.net> <20131122182632.GW4138@linux.vnet.ibm.com> <20131122185107.GJ4971@laptop.programming.kicks-ass.net> <20131125173540.GK3694@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131125173540.GK3694@twins.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org To: Peter Zijlstra , "Paul E. McKenney" Cc: Will Deacon , Tim Chen , Ingo Molnar , Andrew Morton , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-mm , "linux-arch@vger.kernel.org" , Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Rik van Riel , Peter Hurley , Raghavendra List-Id: linux-arch.vger.kernel.org On 11/25/2013 09:35 AM, Peter Zijlstra wrote: > > I think this means x86 needs help too. > > Consider: > > x = y = 0 > > w[x] = 1 | w[y] = 1 > mfence | mfence > r[y] = 0 | r[x] = 0 > > This is generally an impossible case, right? (Since if we observe y=0 > this means that w[y]=1 has not yet happened, and therefore x=1, and > vice-versa). > > Now replace one of the mfences with smp_store_release(l1); > smp_load_acquire(l2); such that we have a RELEASE+ACQUIRE pair that > _should_ form a full barrier: > > w[x] = 1 | w[y] = 1 > w[l1] = 1 | mfence > r[l2] = 0 | r[x] = 0 > r[y] = 0 | > > At which point we can observe the impossible, because as per the rule: > > 'reads may be reordered with older writes to different locations' > > Our r[y] can slip before the w[x]=1. > Yes, because although r[l2] and r[y] are ordered with respect to each other, they are allowed to be executed before w[x] and w[l1]. In other words, smp_store_release() followed by smp_load_acquire() to a different location do not form a full barrier. To the *same* location, they will. -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org