Received: from eggs.gnu.org ([2001:4830:134:3::10]:54783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtQLb-0003od-Fk
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 18:16:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtQLU-0004Cx-LB
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 18:16:11 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49354 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VtQLU-0004Ck-F6
	for qemu-devel@nongnu.org; Wed, 18 Dec 2013 18:16:04 -0500
Message-ID: <52B22CAF.9070603@suse.de>
Date: Thu, 19 Dec 2013 00:15:59 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1387244071.git.peter.crosthwaite@xilinx.com>
	<99da8f561252a97b53c5ec2e5006c5b44f25c5f6.1387244071.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <99da8f561252a97b53c5ec2e5006c5b44f25c5f6.1387244071.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 01/11] char/cadence_uart: Mark struct
 fields as public/private
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, antonynpavlov@gmail.com

Am 17.12.2013 02:40, schrieb Peter Crosthwaite:
> As per current QOM conventions.
>=20
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>=20
>  hw/char/cadence_uart.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c
> index f18db53..2f19a53 100644
> --- a/hw/char/cadence_uart.c
> +++ b/hw/char/cadence_uart.c
> @@ -110,7 +110,9 @@
>  #define CADENCE_UART(obj) OBJECT_CHECK(UartState, (obj), TYPE_CADENCE_=
UART)
> =20
>  typedef struct {
> +    /* <private> */
>      SysBusDevice parent_obj;
> +    /* <public> */

Note that it's /*< ... >*/ if I'm not mistaken.

However since this is outside include/ it won't get parsed by the
patches flying around. This being Cadence IP that is likely to be reused
on other SoCs, I do guess we'll end up with an
include/hw/char/cadence_uart.h at some point.

Cheers,
Andreas

> =20
>      MemoryRegion iomem;
>      uint32_t r[R_MAX];

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg